From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Ub4ds-0005Qu-Hf for mharc-grub-devel@gnu.org; Sat, 11 May 2013 03:54:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub4do-0005QL-S9 for grub-devel@gnu.org; Sat, 11 May 2013 03:54:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ub4dn-000238-Ua for grub-devel@gnu.org; Sat, 11 May 2013 03:54:52 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:53145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ub4dn-00022x-Nj for grub-devel@gnu.org; Sat, 11 May 2013 03:54:51 -0400 Received: by mail-lb0-f175.google.com with SMTP id w20so4843009lbh.6 for ; Sat, 11 May 2013 00:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:in-reply-to:references :x-mailer:mime-version:content-type; bh=FMlIgnUxmnihlJVULYLp3VFFDfNr4Rr16ZVtOjRnbPY=; b=U6mJSqWEo+1KeRq4gvViY9uVPCs9pIhDvMQq/XijFBBjwCTb0rQwtmsJsI5Ttw0+wL gcsz8gSv7osAwoM5kx0tJ9JmPMUq+BxeSneCxmYHkK+l8ig9fPuetF3fNkGa/36A0ph4 8JumgFkM7FN//fsZxgM9W5WjHtTh5eNE2FE0rIGuMvI+Fm43lC4WAQrFa5bmKoDk98tZ sFu2XuQgVWXlJ6gDmt2x6MRT3p130PZnxBTHgezTjFfBNCBCrWhIoRfib3K13k68RAVc XjOZzA7hs54oHhxzL5IubrtwNOawpgi+ddAMxg69BrLh1RKFIsIEFLVZNddAHGIawpNp kDDw== X-Received: by 10.112.89.104 with SMTP id bn8mr9174227lbb.92.1368258890575; Sat, 11 May 2013 00:54:50 -0700 (PDT) Received: from opensuse.site ([94.29.72.160]) by mx.google.com with ESMTPSA id y1sm2069947lay.3.2013.05.11.00.54.49 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Sat, 11 May 2013 00:54:50 -0700 (PDT) Date: Sat, 11 May 2013 11:54:49 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] fix grub-install efibootmgr presence test with --removable Message-ID: <20130511115449.30d05654@opensuse.site> In-Reply-To: <518DE9DC.1040005@gmail.com> References: <20130509104434.GG28516@rocoto.smurfnet.nu> <518D0AE2.4010606@gmail.com> <20130511084312.4bfc9ac6@opensuse.site> <518DE9DC.1040005@gmail.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.14; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/MPwXHx0f4n2tOb/SBzBw1Bb"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.175 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 May 2013 07:54:54 -0000 --Sig_/MPwXHx0f4n2tOb/SBzBw1Bb Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sat, 11 May 2013 08:49:00 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 11.05.2013 06:43, Andrey Borzenkov wrote: >=20 > > =D0=92 Fri, 10 May 2013 16:57:38 +0200 > > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF= =D0=B8=D1=88=D0=B5=D1=82: > >=20 > >> On 09.05.2013 12:44, Leif Lindholm wrote: > >> > >>> When executed for an EFI target, grub-install checks for the path of > >>> efibootmgr - however, this utility is not required (or used) when > >>> installing to a removable media (with --removable). > >>> > >> > >> This patch would simply ignore the problem. I comitted another fix whi= ch > >> is cleaner. > >> > >=20 > > Note that "which command" already prints error message when command was > > not found, so additional error output is strictly speaking redundant. > >=20 >=20 > It doesn't. > phcoder@debian.x201.phnet:08:48:40:~$ which ttt > phcoder@debian.x201.phnet:08:48:41:~$ >=20 This is probably system dependent bor@opensuse:~> which xxx which: no xxx in (/home/bor/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/= usr/X11R6/bin:/usr/games) I guess in this case it is better to redirect stderr to /dev/null --Sig_/MPwXHx0f4n2tOb/SBzBw1Bb Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlGN+UkACgkQR6LMutpd94xLqgCfakuW/CwZ0IFXygtalQYyVE9E IEMAoNF9ys4/4il8CFJw6PeyBkb0CcCM =Pvxi -----END PGP SIGNATURE----- --Sig_/MPwXHx0f4n2tOb/SBzBw1Bb--