From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308Ab3EKPcB (ORCPT ); Sat, 11 May 2013 11:32:01 -0400 Received: from mail-ea0-f169.google.com ([209.85.215.169]:63601 "EHLO mail-ea0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064Ab3EKPb7 (ORCPT ); Sat, 11 May 2013 11:31:59 -0400 Date: Sat, 11 May 2013 17:31:43 +0200 From: Richard Cochran To: Dong Zhu Cc: Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Peter P Waskiewicz Jr , Alex Duyck , John Ronciak , Tushar Dave , Matthew Vick , Jacob Keller , "Paul E. McKenney" , David Howells , Dave Jones , Thomas Gleixner , linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org Subject: Re: [PATCH] igb: add a method to get the nic hw time stamping policy Message-ID: <20130511153143.GA25180@netboy> References: <20130511140219.GG8399@zhudong.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130511140219.GG8399@zhudong.nay.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 11, 2013 at 10:02:19PM +0800, Dong Zhu wrote: > > Currently kernel only support setting the hw time stamping policy > through ioctl,now add a method to check which packets(Outgoing and > Incoming) are time stamped by nic. I don't really see a use case here. Applications needing time stamping should just set the policy that they need. > struct hwtstamp_config { > + int rw; Also, you can't just go adding fields to an ioctl. > int flags; > int tx_type; > int rx_filter; > -- Thanks, Richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH] igb: add a method to get the nic hw time stamping policy Date: Sat, 11 May 2013 17:31:43 +0200 Message-ID: <20130511153143.GA25180@netboy> References: <20130511140219.GG8399@zhudong.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: e1000-devel@lists.sourceforge.net, Bruce Allan , Jesse Brandeburg , linux-kernel@vger.kernel.org, David Howells , John Ronciak , Thomas Gleixner , netdev@vger.kernel.org, Jacob Keller , Dave Jones , "Paul E. McKenney" To: Dong Zhu Return-path: Content-Disposition: inline In-Reply-To: <20130511140219.GG8399@zhudong.nay.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Sat, May 11, 2013 at 10:02:19PM +0800, Dong Zhu wrote: > > Currently kernel only support setting the hw time stamping policy > through ioctl,now add a method to check which packets(Outgoing and > Incoming) are time stamped by nic. I don't really see a use case here. Applications needing time stamping should just set the policy that they need. > struct hwtstamp_config { > + int rw; Also, you can't just go adding fields to an ioctl. > int flags; > int tx_type; > int rx_filter; > -- Thanks, Richard ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired