From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?utf-8?q?St=C3=BCbner?= Subject: Re: [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver Date: Sat, 11 May 2013 17:26:49 +0200 Message-ID: <201305111726.49491.heiko@sntech.de> References: <201305031552.45410.heiko@sntech.de> <046401ce4d15$ccba0c80$662e2580$%kim@samsung.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from gloria.sntech.de ([95.129.55.99]:53141 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752950Ab3EKP05 (ORCPT ); Sat, 11 May 2013 11:26:57 -0400 In-Reply-To: <046401ce4d15$ccba0c80$662e2580$%kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Kukjin Kim Cc: linus.walleij@linaro.org, thomas.abraham@linaro.org, 'Tomasz Figa' , 'Sylwester Nawrocki' , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Am Freitag, 10. Mai 2013, 02:32:05 schrieb Kukjin Kim: > Heiko St=C3=BCbner wrote: > > The s3c24xx pins follow a similar pattern as the other Samsung SoCs= and > > can therefore reuse the already introduced infrastructure. > >=20 > > The s3c24xx SoCs have one design oddity in that the first 4 externa= l > > interrupts do not reside in the eint pending register but in the ma= in > > interrupt controller instead. We solve this by forwarding the exter= nal > > interrupt from the main controller into the irq domain of the pin b= ank. > > The masking/acking of these interrupts is handled in the same way. > >=20 > > Furthermore the S3C2412/2413 SoCs contain another oddity in that th= ey > > keep the same 4 eints in the main interrupt controller and eintpend > > register and requiring ack operations to happen in both. This is so= lved > > by using different compatible properties for the wakeup eint node w= hich > > set a property accordingly. > >=20 > > Signed-off-by: Heiko Stuebner > > Reviewed-by: Tomasz Figa > > Reviewed-by: Sylwester Nawrocki > > Acked-by: Linus Walleij >=20 > Looks good to me. >=20 > Linus, if you want me to take into samsung tree, please let me know. in v4 Linus said: "Are you taking this through the Samsung tree?" This would also enable me to put the s3c2416 devicetree support on top = of it=20 in this cycle, which of course needs the pinctrl driver. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?utf-8?q?St=C3=BCbner?=) Date: Sat, 11 May 2013 17:26:49 +0200 Subject: [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver In-Reply-To: <046401ce4d15$ccba0c80$662e2580$%kim@samsung.com> References: <201305031552.45410.heiko@sntech.de> <046401ce4d15$ccba0c80$662e2580$%kim@samsung.com> Message-ID: <201305111726.49491.heiko@sntech.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Freitag, 10. Mai 2013, 02:32:05 schrieb Kukjin Kim: > Heiko St?bner wrote: > > The s3c24xx pins follow a similar pattern as the other Samsung SoCs and > > can therefore reuse the already introduced infrastructure. > > > > The s3c24xx SoCs have one design oddity in that the first 4 external > > interrupts do not reside in the eint pending register but in the main > > interrupt controller instead. We solve this by forwarding the external > > interrupt from the main controller into the irq domain of the pin bank. > > The masking/acking of these interrupts is handled in the same way. > > > > Furthermore the S3C2412/2413 SoCs contain another oddity in that they > > keep the same 4 eints in the main interrupt controller and eintpend > > register and requiring ack operations to happen in both. This is solved > > by using different compatible properties for the wakeup eint node which > > set a property accordingly. > > > > Signed-off-by: Heiko Stuebner > > Reviewed-by: Tomasz Figa > > Reviewed-by: Sylwester Nawrocki > > Acked-by: Linus Walleij > > Looks good to me. > > Linus, if you want me to take into samsung tree, please let me know. in v4 Linus said: "Are you taking this through the Samsung tree?" This would also enable me to put the s3c2416 devicetree support on top of it in this cycle, which of course needs the pinctrl driver. Heiko