From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754779Ab3ELRZI (ORCPT ); Sun, 12 May 2013 13:25:08 -0400 Received: from mail-ea0-f182.google.com ([209.85.215.182]:58769 "EHLO mail-ea0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754568Ab3ELRZG (ORCPT ); Sun, 12 May 2013 13:25:06 -0400 Date: Sun, 12 May 2013 19:24:46 +0200 From: Richard Cochran To: Dong Zhu Cc: Sergei Shtylyov , Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Peter P Waskiewicz Jr , Alex Duyck , John Ronciak , Tushar Dave , Matthew Vick , Jacob Keller , "Paul E. McKenney" , David Howells , Dave Jones , Thomas Gleixner , linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org Subject: Re: [PATCH] igb: add a method to get the nic hw time stamping policy Message-ID: <20130512172446.GA2484@netboy> References: <20130511140219.GG8399@zhudong.nay.redhat.com> <518E7723.5010003@cogentembedded.com> <20130512142555.GI8399@zhudong.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130512142555.GI8399@zhudong.nay.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 12, 2013 at 10:25:55PM +0800, Dong Zhu wrote: > Thanks for your pointing out my mistakes of CodingStyle. > > > > struct hwtstamp_config { > > >+ int rw; > > My initial idea was that the type of rw should be enum like tx_type, but I am > not sure whther it is necessary to define a new enum, if this patch could > be accpeted I will ask someone about the rw. At that time I will change > the type of rw to bool or define a new enum, then convert the if to > switch if necessary. You cannot add any new field at all. That would break a userland ABI. Thanks, Richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH] igb: add a method to get the nic hw time stamping policy Date: Sun, 12 May 2013 19:24:46 +0200 Message-ID: <20130512172446.GA2484@netboy> References: <20130511140219.GG8399@zhudong.nay.redhat.com> <518E7723.5010003@cogentembedded.com> <20130512142555.GI8399@zhudong.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Sergei Shtylyov , e1000-devel@lists.sourceforge.net, Bruce Allan , Jesse Brandeburg , linux-kernel@vger.kernel.org, David Howells , John Ronciak , Thomas Gleixner , netdev@vger.kernel.org, Jacob Keller , Dave Jones , "Paul E. McKenney" To: Dong Zhu Return-path: Content-Disposition: inline In-Reply-To: <20130512142555.GI8399@zhudong.nay.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Sun, May 12, 2013 at 10:25:55PM +0800, Dong Zhu wrote: > Thanks for your pointing out my mistakes of CodingStyle. > > > > struct hwtstamp_config { > > >+ int rw; > > My initial idea was that the type of rw should be enum like tx_type, but I am > not sure whther it is necessary to define a new enum, if this patch could > be accpeted I will ask someone about the rw. At that time I will change > the type of rw to bool or define a new enum, then convert the if to > switch if necessary. You cannot add any new field at all. That would break a userland ABI. Thanks, Richard ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired