All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: "backports@vger.kernel.org" <backports@vger.kernel.org>
Subject: Re: [RFC] backports: add remove_proc_subtree() backport
Date: Mon, 13 May 2013 06:40:42 +0100	[thread overview]
Message-ID: <20130513054042.GU25399@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAB=NE6UeupVx+DPuwg1hh1Y09Bb1vF08uObvpyhBS1wwMFUaZw@mail.gmail.com>

On Sun, May 12, 2013 at 10:21:02PM -0700, Luis R. Rodriguez wrote:

> > The difference from your variant is that you use the stack to hold
> > pointers to ancestors of the current victim.  You get to the parent
> > of said victim by discarding a stack frame.  No need, since the
> > victim contained an explicit pointer to its parent...
> 
> Except I thought NULL was passed?

AFAICS, your variant removes _everything_ in the parent.  IOW, instead
of
	rm -rf $ROOT/$RELATIVE_PATH
you do
	test -n $ROOT && rm -rf $ROOT/*
	rm $ROOT/$RELATIVE_PATH
which is not the same thing...

  reply	other threads:[~2013-05-13  5:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13  4:31 [RFC] backports: add remove_proc_subtree() backport Luis R. Rodriguez
2013-05-13  5:03 ` Al Viro
2013-05-13  5:21   ` Luis R. Rodriguez
2013-05-13  5:40     ` Al Viro [this message]
2013-05-13  6:14       ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130513054042.GU25399@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=backports@vger.kernel.org \
    --cc=mcgrof@do-not-panic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.