From: John Keeping <john@keeping.me.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] patch-ids.c: cache patch IDs in a notes tree
Date: Mon, 13 May 2013 15:02:43 +0100 [thread overview]
Message-ID: <20130513140243.GQ2299@serenity.lan> (raw)
In-Reply-To: <7vzjvzoujq.fsf@alter.siamese.dyndns.org>
On Mon, May 13, 2013 at 06:53:29AM -0700, Junio C Hamano wrote:
> John Keeping <john@keeping.me.uk> writes:
>
> > The caching layer could also introduce false positives though, which is
> > more serious. If you cache patch IDs with a pathspec restriction ...
>
> What? What business does patch-id have with pathspec-limited diff
> generation? You do not rebase or cherry-pick with pathspec, so
> unless you are populating the patch-id cache at a wrong point (like,
> say whenevern "git show $commit" is run), I am not sure why pathspec
> limit becomes even an issue.
revision.c::cherry_pick_list() sets the pathspec to what was specified
in the revision options. It's done that since commit 36d56de (Fix
--cherry-pick with given paths, 2007-07-10) and t6007 tests that it
works.
next prev parent reply other threads:[~2013-05-13 14:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 19:54 [PATCH] patch-ids.c: cache patch IDs in a notes tree John Keeping
2013-05-11 21:10 ` Linus Torvalds
2013-05-11 21:49 ` John Keeping
2013-05-11 22:41 ` Linus Torvalds
2013-05-11 23:57 ` Johannes Schindelin
2013-05-12 9:08 ` John Keeping
2013-05-12 11:41 ` [RFC/PATCH v2] patch-ids: " John Keeping
2013-05-12 11:57 ` John Keeping
2013-05-12 3:00 ` [PATCH] patch-ids.c: " Junio C Hamano
2013-05-12 8:59 ` John Keeping
2013-05-12 22:19 ` Junio C Hamano
2013-05-13 7:59 ` John Keeping
2013-05-13 13:53 ` Junio C Hamano
2013-05-13 14:02 ` John Keeping [this message]
2013-05-13 14:46 ` Junio C Hamano
2013-05-13 14:59 ` John Keeping
2013-05-13 15:45 ` Junio C Hamano
2013-05-13 15:52 ` John Keeping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513140243.GQ2299@serenity.lan \
--to=john@keeping.me.uk \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.