From: Martin Jansa <martin.jansa@gmail.com>
To: Phil Blundell <pb@pbcl.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 0/5] Enable VPN support in ConnMan
Date: Mon, 13 May 2013 16:42:37 +0200 [thread overview]
Message-ID: <20130513144237.GC3187@jama> (raw)
In-Reply-To: <1368453851.6920.11.camel@phil-desktop.brightsign>
[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]
On Mon, May 13, 2013 at 03:04:11PM +0100, Phil Blundell wrote:
> On Mon, 2013-05-13 at 16:55 +0300, Jukka Rissanen wrote:
> > On 13.05.2013 16:39, Martin Jansa wrote:
> > >> Jukka Rissanen (5):
> > >> connman: Add VPN support
> > >> connman: Add OpenVPN support
> > >> connman: Add vpnc support
> > >> connman: Add L2TP support
> > >> connman: Add PPTP support
> > >
> > > I think that 2-5 are missing
> > >
> > > PACKAGES =+ "${PN}-vpn-foo"
> > >
> >
> > The individual vpn plugin packages were created and added to distro
> > without a problem even if they were not in PACKAGES.
> > But I can certainly send another version that adds these.
>
> If it's using do_split_packages() then you don't need to (and shouldn't)
> add those things to PACKAGES directly.
>
> You might consider patching connman.inc to add the INSANE_SKIP stuff
> automatically since all the plugins will presumably need that treatment.
Ah, I've overlooked do_split_packages in 1/5 and was surprised to see
only SUMMARY/FILES additions in 2-5.
I'm sorry for noise.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
prev parent reply other threads:[~2013-05-13 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 12:49 [PATCH v2 0/5] Enable VPN support in ConnMan Jukka Rissanen
2013-05-13 12:49 ` [PATCH v2 1/5] connman: Add VPN support Jukka Rissanen
2013-05-13 15:20 ` Phil Blundell
2013-05-13 12:49 ` [PATCH v2 2/5] connman: Add OpenVPN support Jukka Rissanen
2013-05-13 12:49 ` [PATCH v2 3/5] connman: Add vpnc support Jukka Rissanen
2013-05-13 12:49 ` [PATCH v2 4/5] connman: Add L2TP support Jukka Rissanen
2013-05-13 12:49 ` [PATCH v2 5/5] connman: Add PPTP support Jukka Rissanen
2013-05-13 13:39 ` [PATCH v2 0/5] Enable VPN support in ConnMan Martin Jansa
2013-05-13 13:55 ` Jukka Rissanen
2013-05-13 14:04 ` Phil Blundell
2013-05-13 14:42 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513144237.GC3187@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pb@pbcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.