From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT
Date: Mon, 13 May 2013 15:07:14 -0400 [thread overview]
Message-ID: <20130513190714.GE29196@bill-the-cat> (raw)
In-Reply-To: <1368232126.19683.19@snotra>
On Fri, May 10, 2013 at 07:28:46PM -0500, Scott Wood wrote:
> On 05/10/2013 07:03:07 PM, Wolfgang Denk wrote:
> >Dear ying.zhang at freescale.com,
> >
> >In message
> ><1368182421-859-1-git-send-email-ying.zhang@freescale.com> you
> >wrote:
> >> From: Ying Zhang <b40530@freescale.com>
> >>
> >> Add a new symbol CONFIG_SPL_ENV_SUPPORT to replace
> >CONFIG_SPL_NET_SUPPORT.
> >
> >Any CONFIG_* stuff must be documented in the README. Please add this
> >documentation.
> >
> >> In common/Makefile, the environment-related files in SPL is
> >difined by
> >> CONFIG_SPL_NET_SUPPORT, it is wrong.
> >
> >s/difined/defined/
> >
> >Could you please also explain, what exactly is wrong, and how your new
> >code fixes this?
>
> We will need the environment in SPL for reasons other than network
> support (in particular, hwconfig contains info for how to set up
> DDR). Yes, this information should go in the changelog.
Note that a3m071 already does SPL + Environment and should be updated,
CONFIG-symbol wise here. It currently gets away with
env_common/cmd_nvedit being pulled in always on LIBCOMMON and then
discarded when not needed.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130513/751d90c3/attachment.pgp>
prev parent reply other threads:[~2013-05-13 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 10:40 [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT to replace CONFIG_SPL_NET_SUPPORT ying.zhang at freescale.com
2013-05-11 0:03 ` Wolfgang Denk
2013-05-11 0:28 ` Scott Wood
2013-05-13 7:19 ` Zhang Ying-B40530
2013-05-13 19:07 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130513190714.GE29196@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.