From: Greg KH <gregkh@linuxfoundation.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
ohering@suse.com, jbottomley@parallels.com, hch@infradead.org,
linux-scsi@vger.kernel.org, apw@canonical.com,
jasowang@redhat.com
Subject: Re: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support
Date: Thu, 16 May 2013 00:01:30 -0400 [thread overview]
Message-ID: <20130516040130.GB16728@kroah.com> (raw)
In-Reply-To: <1368655354-27651-1-git-send-email-kys@microsoft.com>
On Wed, May 15, 2013 at 03:02:29PM -0700, K. Y. Srinivasan wrote:
> +/*
> + * Retrieve the (sub) channel on which to send an outgoing request.
> + * When a primary channel has multiple sub-channels, we choose a
> + * channel whose VCPU binding is closest to the VCPU on which
> + * this call is being made.
> + */
> +struct vmbus_channel *get_outgoing_channel(struct vmbus_channel *primary)
That's a _very_ vague global symbol name you are adding to the kernel.
Same goes for the other functions you are adding here, please fix that,
and make them have the vmbus_ prefix, like everything else in this
patch.
So, sorry, no ack here.
greg k-h
next prev parent reply other threads:[~2013-05-16 4:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 22:02 [PATCH 0/6] Drivers: hv/scsi: Implement multi-channel support K. Y. Srinivasan
2013-05-15 22:02 ` [PATCH 1/6] Drivers: hv: vmbus: " K. Y. Srinivasan
2013-05-15 22:02 ` [PATCH 2/6] Drivers: hv: Add the GUID fot synthetic fiber channel device K. Y. Srinivasan
2013-05-16 4:01 ` Greg KH
2013-05-15 22:02 ` [PATCH 3/6] Drivers: scsi: storvsc: Make the scsi timeout a module parameter K. Y. Srinivasan
2013-05-15 22:02 ` [PATCH 4/6] Drivers: scsi: storvsc: Update the storage protocol to win8 level K. Y. Srinivasan
2013-05-15 22:02 ` [PATCH 5/6] Drivers: scsi: storvsc: Implement multi-channel support K. Y. Srinivasan
2013-05-15 22:02 ` [PATCH 6/6] Drivers: scsi: storvsc: Support FC devices K. Y. Srinivasan
2013-05-15 22:02 ` K. Y. Srinivasan
2013-05-16 4:01 ` Greg KH [this message]
2013-05-16 10:18 ` [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support KY Srinivasan
2013-05-16 4:00 ` [PATCH 0/6] Drivers: hv/scsi: " Greg KH
2013-05-16 10:15 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516040130.GB16728@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jbottomley@parallels.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ohering@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.