All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Deegan <tim@xen.org>
To: Kouya Shimura <kouya@jp.fujitsu.com>
Cc: Keir Fraser <keir@xen.org>, Alex Bligh <alex@alex.org.uk>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] x86/hvm: fix corrupt ACPI PM-Timer during live migration
Date: Thu, 16 May 2013 10:54:24 +0100	[thread overview]
Message-ID: <20130516095424.GA92045@ocelot.phlegethon.org> (raw)
In-Reply-To: <51946E2E.1040707@jp.fujitsu.com>

At 14:27 +0900 on 16 May (1368714430), Kouya Shimura wrote:
> Hi Keir, Tim,
> 
> I attached the patch again.
> Can I get an ACK or NACK?

Well, I don't think this is suitable for committing:

> +#if 0 /* redundant */
>      if ( !mode_is(v->domain, delay_for_missed_ticks) )
>          return;
> +#endif

but apart from that it seems OK to me.  It's a bit odd to have the
platform timers (almost) stop ticking when their controlling vcpu is
descheduled but I guess no worse than having them go backwards!

So if you fix the '#if 0' (either cut out the code properly or leave it
alone, I don't mind which), you can add

Reviewed-by: Tim Deegan <tim@xen.org>

You'll need an ack from George as well for the release; I suspect that
will depend on how much testing you've done.

Tim.

      reply	other threads:[~2013-05-16  9:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05  6:12 [PATCH] x86/hvm: fix corrupt ACPI PM-Timer during live migration Kouya Shimura
2013-02-12 12:26 ` Jan Beulich
2013-02-14  6:09   ` Kouya Shimura
2013-02-15 16:45     ` Jan Beulich
2013-02-20  7:42       ` Kouya Shimura
2013-03-07 15:58         ` Jan Beulich
2013-03-08  7:59           ` Kouya Shimura
2013-03-21  7:31           ` Kouya Shimura
2013-03-21  8:05             ` Jan Beulich
     [not found]           ` <514A9BC4.40508@jp.fujitsu.com>
2013-03-21  7:32             ` [PATCH 1/2] x86/hvm: prevent guest's timers from going backwards, when timer_mode=0 Kouya Shimura
2013-03-21  7:32             ` [PATCH 2/2] x86/hvm: fix corrupt ACPI PM-Timer during live migration Kouya Shimura
2013-03-21 10:01               ` Jan Beulich
2013-03-22  1:12                 ` Kouya Shimura
2013-03-22  8:02                   ` Jan Beulich
2013-05-15 14:23                     ` Alex Bligh
2013-05-15 14:31                       ` Jan Beulich
2013-05-15 14:49                         ` Alex Bligh
2013-05-15 14:54                           ` Jan Beulich
2013-05-16  5:29                             ` Kouya Shimura
2013-05-16 10:38                               ` Alex Bligh
2013-05-16  5:27                         ` Kouya Shimura
2013-05-16  9:54                           ` Tim Deegan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516095424.GA92045@ocelot.phlegethon.org \
    --to=tim@xen.org \
    --cc=JBeulich@suse.com \
    --cc=alex@alex.org.uk \
    --cc=keir@xen.org \
    --cc=kouya@jp.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.