All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Afschin Hormozdiary <Afschin.Hormozdiary@sophos.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH next] libnetfilter_conntrack: don't ignore ATTR_CONNLABELS
Date: Thu, 16 May 2013 12:47:00 +0200	[thread overview]
Message-ID: <20130516104700.GA3984@localhost> (raw)
In-Reply-To: <a17383ac-860c-4a6f-baf1-a382ce895a5c@DE-WIE-EXCH3A.green.sophos>

On Thu, May 16, 2013 at 11:30:43AM +0200, Afschin Hormozdiary wrote:
> The libnfnetlink based backend 'build.c' currently ignores
> ATTR_CONNLABELS and ATTR_CONNLABELS_MASK.
> 
> The libmnl based backend 'build_mnl.c' instead handles
> both attributes correct.
> 
> Add function to set CTA_LABELS and CTA_LABELS_MASK
> if required.

I'm fine with this change, but you also need to modify the parsing
function not to leave connlabel support for the libnfnetlink-based API
incomplete.

  reply	other threads:[~2013-05-16 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-16  9:30 [PATCH next] libnetfilter_conntrack: don't ignore ATTR_CONNLABELS Afschin Hormozdiary
2013-05-16 10:47 ` Pablo Neira Ayuso [this message]
2013-05-17  7:33   ` Afschin Hormozdiary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516104700.GA3984@localhost \
    --to=pablo@netfilter.org \
    --cc=Afschin.Hormozdiary@sophos.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.