All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH] mm/THP: Use pmd_populate to update the pmd with pgtable_t pointer
Date: Thu, 16 May 2013 15:18:04 +0200	[thread overview]
Message-ID: <20130516131804.GO5181@redhat.com> (raw)
In-Reply-To: <87txm6537l.fsf@linux.vnet.ibm.com>

Hi Aneesh,

On Mon, May 13, 2013 at 08:36:38PM +0530, Aneesh Kumar K.V wrote:
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-May/106406.html

You need ACCESS_ONCE() in all "pgd = ACCESS_ONCE(*pgdp)", "pud =
ACCESS_ONCE(*pudp)" otherwise the compiler could decide your change is
a noop.

I think you could remove the #ifdef CONFIG_TRANSPARENT_HUGEPAGE too.

Thanks,
Andrea

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-05-16 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-12  8:35 [PATCH] mm/THP: Use pmd_populate to update the pmd with pgtable_t pointer Aneesh Kumar K.V
2013-05-13 13:48 ` Aneesh Kumar K.V
2013-05-13 14:13   ` Andrea Arcangeli
2013-05-13 14:44     ` Aneesh Kumar K.V
2013-05-13 15:06       ` Aneesh Kumar K.V
2013-05-16 13:18         ` Andrea Arcangeli [this message]
2013-05-16 14:25           ` Aneesh Kumar K.V
2013-05-16 14:51             ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130516131804.GO5181@redhat.com \
    --to=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.