From: Oleg Nesterov <oleg@redhat.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Colin Walters <walters@verbum.org>,
Denys Vlasenko <vda.linux@googlemail.com>,
Jiri Slaby <jslaby@suse.cz>,
Lennart Poettering <mzxreary@0pointer.de>,
Neil Horman <nhorman@tuxdriver.com>,
security@kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] usermodehelper: check subprocess_info->path != NULL
Date: Thu, 16 May 2013 19:13:37 +0200 [thread overview]
Message-ID: <20130516171337.GA24031@redhat.com> (raw)
In-Reply-To: <CAKi4VAKj+s0Z9QHfqwG3+y33puL4dVaou5ys+eiD-yLf8h5QrA@mail.gmail.com>
On 05/16, Lucas De Marchi wrote:
>
> >
> > - kill or justify ->path[0] check
>
> I'm not sure about this, it's already there before my refactor and I
> don't think it makes any good. From modprobe pespective, I'd say it
> would be better to give an error than say everything went ok.
Agreed. And, I forgot to mention, if we kill this check then we do
not need this patch (although I need to recheck), execve will fail
and nothing bad should happen.
Just I think it would be better to start with the trivial fix, then
decide what should we actually do.
> Acked-By: Lucas De Marchi <lucas.demarchi@intel.com>
Thanks,
Oleg.
next prev parent reply other threads:[~2013-05-16 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 20:11 [PATCH 0/6] coredump: format_corename() fixes/cleanups Oleg Nesterov
2013-05-15 20:12 ` [PATCH 1/6] coredump: format_corename() can leak cn->corename Oleg Nesterov
2013-05-15 20:12 ` [PATCH 2/6] coredump: introduce cn_vprintf() Oleg Nesterov
2013-05-15 20:12 ` [PATCH 3/6] coredump: cn_vprintf() has no reason to call vsnprintf() twice Oleg Nesterov
2013-05-15 20:12 ` [PATCH 4/6] coredump: kill cn_escape(), introduce cn_esc_printf() Oleg Nesterov
2013-05-15 20:26 ` [PATCH v2 " Oleg Nesterov
2013-05-15 20:12 ` [PATCH 5/6] coredump: kill call_count, add core_name_size Oleg Nesterov
2013-05-24 19:53 ` Andrew Morton
2013-05-27 15:16 ` Oleg Nesterov
2013-05-15 20:12 ` [PATCH 6/6] coredump: '% at the end' shouldn't bypass core_uses_pid logic Oleg Nesterov
2013-05-16 13:28 ` [PATCH 0/6] coredump: format_corename() fixes/cleanups Neil Horman
[not found] ` <20130516154323.GA19060@redhat.com>
2013-05-16 15:43 ` [PATCH 1/1] usermodehelper: check subprocess_info->path != NULL Oleg Nesterov
2013-05-16 16:16 ` Lucas De Marchi
2013-05-16 17:13 ` Oleg Nesterov [this message]
[not found] ` <20130516182624.GA29455@redhat.com>
2013-05-16 18:38 ` [PATCH 7/6] coredump: avoid the uninitialized cn->corename if core_pattern is empty Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516171337.GA24031@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=mzxreary@0pointer.de \
--cc=nhorman@tuxdriver.com \
--cc=security@kernel.org \
--cc=vda.linux@googlemail.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.