From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP: fix error return code in omap1_system_dma_init() Date: Thu, 16 May 2013 10:48:47 -0700 Message-ID: <20130516174847.GD5600@atomide.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:11967 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751744Ab3EPRs4 (ORCPT ); Thu, 16 May 2013 13:48:56 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Wei Yongjun Cc: linux@arm.linux.org.uk, yongjun_wei@trendmicro.com.cn, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org * Wei Yongjun [130512 21:30]: > From: Wei Yongjun > > Fix to return -ENOMEM in the d->chan alloc error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Thanks, applying into omap-for-v3.10/fixes. Regards, Tony > --- > arch/arm/mach-omap1/dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c > index 68ab858..a94b3a7 100644 > --- a/arch/arm/mach-omap1/dma.c > +++ b/arch/arm/mach-omap1/dma.c > @@ -345,6 +345,7 @@ static int __init omap1_system_dma_init(void) > dev_err(&pdev->dev, > "%s: Memory allocation failed for d->chan!\n", > __func__); > + ret = -ENOMEM; > goto exit_release_d; > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 16 May 2013 10:48:47 -0700 Subject: [PATCH] ARM: OMAP: fix error return code in omap1_system_dma_init() In-Reply-To: References: Message-ID: <20130516174847.GD5600@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Wei Yongjun [130512 21:30]: > From: Wei Yongjun > > Fix to return -ENOMEM in the d->chan alloc error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Thanks, applying into omap-for-v3.10/fixes. Regards, Tony > --- > arch/arm/mach-omap1/dma.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-omap1/dma.c b/arch/arm/mach-omap1/dma.c > index 68ab858..a94b3a7 100644 > --- a/arch/arm/mach-omap1/dma.c > +++ b/arch/arm/mach-omap1/dma.c > @@ -345,6 +345,7 @@ static int __init omap1_system_dma_init(void) > dev_err(&pdev->dev, > "%s: Memory allocation failed for d->chan!\n", > __func__); > + ret = -ENOMEM; > goto exit_release_d; > } > >