From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, arpad@andrews.hu
Subject: Re: [PATCH] netfilter: add and use nf_afinfo in xt_addrtype
Date: Thu, 16 May 2013 20:47:51 +0200 [thread overview]
Message-ID: <20130516184751.GA29218@breakpoint.cc> (raw)
In-Reply-To: <20130516161530.GA7533@localhost>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> ipv6_find_hdr was also moved from ip6tables to ipv6 core code
> recently. Now we got a hard dependency on ipv6 if Hans' HMARK is used
> as well. So we need another hook for it. Again, that function is
> pretty specific of IPv6. So I think that we can add a new struct
> nf_afinfo_ipv6 to keep IPv6-only hooks like this and the one for
> ipv6_find.
Alright, i'll re-work this patch into a series, first adding
such a new struct. We can then fix other dependency crap
later as time permits.
> I don't like putting this into nf_afinfo either, since it's specific
> of IPv6, but I want a small fix that fulfill the -stable rules. It
> will take some time until people get the fix for xt_addrtype IPv6 if
> we make it the nice way.
True, although this isn't a regression.
> Seems like merge ipt and ip6t module is bringing us more problems that
> expected.
Yes, and I think that separating all of those again is not realistic, so
a new ipv6 specific hook struct seems like the best shot.
prev parent reply other threads:[~2013-05-16 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 11:47 [PATCH] netfilter: add and use nf_afinfo in xt_addrtype Florian Westphal
2013-05-16 16:15 ` Pablo Neira Ayuso
2013-05-16 18:47 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516184751.GA29218@breakpoint.cc \
--to=fw@strlen.de \
--cc=arpad@andrews.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.