From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Julius Werner <jwerner@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org,
Vincent Palatin <vpalatin@chromium.org>,
Sameer Nanda <snanda@chromium.org>
Subject: Re: [PATCH v3] usb: ehci: Only sleep for post-resume handover if devices use persist
Date: Thu, 16 May 2013 17:42:31 -0700 [thread overview]
Message-ID: <20130517004231.GA32618@kroah.com> (raw)
In-Reply-To: <1366906107-22669-1-git-send-email-jwerner@chromium.org>
On Thu, Apr 25, 2013 at 09:08:27AM -0700, Julius Werner wrote:
> The current EHCI code sleeps a flat 110ms in the resume path if there
> was a USB 1.1 device connected to its companion controller during
> suspend, waiting for the device to reappear and reset so that it can be
> handed back to the companion. This is necessary if the device uses
> persist, so that the companion controller can actually see it during its
> own resume path.
>
> However, if the device doesn't use persist, this is entirely
> unnecessary. We might just as well ignore it and have the normal device
> detection/reset/handoff code handle it asynchronously when it eventually
> shows up. As USB 1.1 devices are almost exclusively HIDs these days (for
> which persist has no value), this can allow distros to shave another
> tenth of a second off their resume time.
>
> In order to enable this optimization, the patch also adds a new
> usb_for_each_dev() iterator that is exported by the USB core and wraps
> bus_for_each_dev() with the logic to differentiate between struct
> usb_device and struct usb_interface on the usb_bus_type bus.
>
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> ---
> drivers/usb/core/usb.c | 33 +++++++++++++++++++++++++++++++++
> drivers/usb/host/ehci-hub.c | 17 +++++++++++++++++
> include/linux/usb.h | 1 +
> 3 files changed, 51 insertions(+)
This patch is corrupted somehow, but I can't figure out how.
I'm getting the error:
checking file drivers/usb/core/usb.c
checking file drivers/usb/host/ehci-hub.c
patch: **** malformed patch at line 164: @@ -56,6 +63,16 @@ static void ehci_handover_companion_ports(struct ehci_hcd *ehci)
when trying to apply it. git also doesn't like it.
Care to fix this up and resend it so I can apply it?
thanks,
greg k-h
next prev parent reply other threads:[~2013-05-17 3:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 16:08 [PATCH v3] usb: ehci: Only sleep for post-resume handover if devices use persist Julius Werner
2013-05-17 0:42 ` Greg Kroah-Hartman [this message]
2013-05-17 19:08 ` [PATCH v4] " Julius Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517004231.GA32618@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=snanda@chromium.org \
--cc=stern@rowland.harvard.edu \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.