From: Borislav Petkov <bp@alien8.de>
To: tony.luck@intel.com, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/2] ACPI/APEI: Add parameter check before error injection
Date: Fri, 17 May 2013 11:07:16 +0200 [thread overview]
Message-ID: <20130517090716.GA23035@pd.tnic> (raw)
In-Reply-To: <20130517050932.GA30122@gchen.bj.intel.com>
On Fri, May 17, 2013 at 01:09:32AM -0400, Chen Gong wrote:
> IMHO, I don't think your attached patch has obvious improvment. I
> paste my updated patch here and please continue to review. I will send
> updated patch based on your further review.
I already did my review. Having a bool checkparam and querying it
straight afterwards is clumsy code. Also you're adding a redundant
definiton of PAGE_MASK even though it already exists in the kernel.
Maybe you should've grepped the sources first...
Not to mention that this check seems wrong:
((param2 & PAGE_MASK) != PAGE_MASK)
But hey, I have better things to do instead of wasting time with this.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-05-17 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 2:29 Parameter check for EINJ error injection Chen Gong
2013-05-16 2:29 ` [PATCH 1/2] ACPI/APEI: Add parameter check before " Chen Gong
2013-05-16 11:05 ` Borislav Petkov
2013-05-17 5:09 ` Chen Gong
2013-05-17 9:07 ` Borislav Petkov [this message]
2013-05-20 2:13 ` Chen Gong
2013-05-16 2:29 ` [PATCH 2/2] ACPI/APEI: Update einj documentation for param1/param2 Chen Gong
2013-05-16 11:07 ` Borislav Petkov
2013-05-17 5:10 ` Chen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517090716.GA23035@pd.tnic \
--to=bp@alien8.de \
--cc=linux-acpi@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.