From: Peter Zijlstra <peterz@infradead.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux390@de.ibm.com, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] locking: Fix copy/paste errors "ARCH_INLINE_*_UNLOCK_BH"
Date: Fri, 17 May 2013 12:18:24 +0200 [thread overview]
Message-ID: <20130517101824.GA5162@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <1368780693.1350.228.camel@x61.thuisdomein>
On Fri, May 17, 2013 at 10:51:33AM +0200, Paul Bolle wrote:
> The Kconfig symbols ARCH_INLINE_READ_UNLOCK_IRQ,
> ARCH_INLINE_SPIN_UNLOCK_IRQ, and ARCH_INLINE_WRITE_UNLOCK_IRQ were added
> in v2.6.33, but have never actually been used. Ingo Molnar spotted that
> this is caused by three identical copy/paste erros. Eg, the Kconfig
> entry for
> INLINE_READ_UNLOCK_IRQ
>
> has an (optional) dependency on
> ARCH_INLINE_READ_UNLOCK_BH
>
> were it apparently should depend on
> ARCH_INLINE_READ_UNLOCK_IRQ
>
> instead. Likewise for the Kconfig entries for INLINE_SPIN_UNLOCK_IRQ and
> INLINE_WRITE_UNLOCK_IRQ. Fix these three errors.
>
> Reported-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Thanks!
next prev parent reply other threads:[~2013-05-17 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 13:35 [PATCH] locking: remove three unused Kconfig symbols Paul Bolle
2013-04-08 15:16 ` Ingo Molnar
2013-04-08 15:30 ` Paul Bolle
2013-04-08 15:32 ` Paul Bolle
2013-04-08 15:36 ` Ingo Molnar
2013-05-17 8:51 ` [PATCH v2] locking: Fix copy/paste errors "ARCH_INLINE_*_UNLOCK_BH" Paul Bolle
2013-05-17 10:18 ` Peter Zijlstra [this message]
2013-05-28 12:55 ` [tip:core/locking] locking: Fix copy/paste errors of " ARCH_INLINE_*_UNLOCK_BH" tip-bot for Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517101824.GA5162@dyad.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mingo@kernel.org \
--cc=pebolle@tiscali.nl \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.