From: Nishanth Menon <nm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v02 2/2] OMAP5: add ABB setup for MPU voltage domain
Date: Fri, 17 May 2013 08:01:12 -0500 [thread overview]
Message-ID: <20130517130112.GA4892@kahuna> (raw)
In-Reply-To: <1368463777-31980-3-git-send-email-andrii.tseglytskyi@ti.com>
On 19:49-20130513, Andrii Tseglytskyi wrote:
> Patch adds a call of abb_setup() function, and proper registers
> definitions needed for ABB setup sequence. ABB is initialized
> for MPU voltage domain.
>
> Signed-off-by: Andrii Tseglytskyi <andrii.tseglytskyi@ti.com>
> ---
> arch/arm/cpu/armv7/omap-common/clocks-common.c | 9 +++++++++
> arch/arm/cpu/armv7/omap5/prcm-regs.c | 7 +++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c b/arch/arm/cpu/armv7/omap-common/clocks-common.c
> index 2b955c7..bdecaf8 100644
> --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c
> +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c
> @@ -533,6 +533,15 @@ void scale_vcores(struct vcores_data const *vcores)
> do_scale_vcore(vcores->mpu.addr, vcores->mpu.value,
> vcores->mpu.pmic);
>
> + /* Configure MPU ABB LDO after scale */
> + abb_setup((*ctrl)->control_std_fuse_opp_vdd_mpu_2,
> + (*ctrl)->control_wkup_ldovbb_mpu_voltage_ctrl,
> + (*prcm)->prm_abbldo_mpu_setup,
> + (*prcm)->prm_abbldo_mpu_ctrl,
> + (*prcm)->prm_irqstatus_mpu_2,
> + OMAP_ABB_MPU_TXDONE_MASK,
> + OMAP_ABB_FAST_OPP);
> +
> do_scale_vcore(vcores->mm.addr, vcores->mm.value,
> vcores->mm.pmic);
>
> diff --git a/arch/arm/cpu/armv7/omap5/prcm-regs.c b/arch/arm/cpu/armv7/omap5/prcm-regs.c
> index b8a61fe..b4b624e 100644
> --- a/arch/arm/cpu/armv7/omap5/prcm-regs.c
> +++ b/arch/arm/cpu/armv7/omap5/prcm-regs.c
> @@ -311,6 +311,7 @@ struct prcm_regs const omap5_es1_prcm = {
>
> struct omap_sys_ctrl_regs const omap5_ctrl = {
> .control_status = 0x4A002134,
> + .control_std_fuse_opp_vdd_mpu_2 = 0x4A0021B4,
> .control_paconf_global = 0x4A002DA0,
> .control_paconf_mode = 0x4A002DA4,
> .control_smart1io_padconf_0 = 0x4A002DA8,
> @@ -358,6 +359,7 @@ struct omap_sys_ctrl_regs const omap5_ctrl = {
> .control_port_emif2_sdram_config = 0x4AE0C118,
> .control_emif1_sdram_config_ext = 0x4AE0C144,
> .control_emif2_sdram_config_ext = 0x4AE0C148,
> + .control_wkup_ldovbb_mpu_voltage_ctrl = 0x4AE0C318,
> .control_smart1nopmio_padconf_0 = 0x4AE0CDA0,
> .control_smart1nopmio_padconf_1 = 0x4AE0CDA4,
> .control_padconf_mode = 0x4AE0CDA8,
> @@ -709,6 +711,9 @@ struct prcm_regs const omap5_es2_prcm = {
> .cm_l3init_fsusb_clkctrl = 0x4a0096d0,
> .cm_l3init_ocp2scp1_clkctrl = 0x4a0096e0,
>
> + /* prm irqstatus regs */
> + .prm_irqstatus_mpu_2 = 0x4ae06014,
> +
> /* l4 wkup regs */
> .cm_abe_pll_ref_clksel = 0x4ae0610c,
> .cm_sys_clksel = 0x4ae06110,
> @@ -739,6 +744,8 @@ struct prcm_regs const omap5_es2_prcm = {
> .prm_sldo_mpu_ctrl = 0x4ae07cd0,
> .prm_sldo_mm_setup = 0x4ae07cd4,
> .prm_sldo_mm_ctrl = 0x4ae07cd8,
> + .prm_abbldo_mpu_setup = 0x4ae07cdc,
> + .prm_abbldo_mpu_ctrl = 0x4ae07ce0,
> };
>
> struct prcm_regs const dra7xx_prcm = {
> --
> 1.7.9.5
>
Overall ok with this, though, I'd like to wait a week before acking this
formally(I should get samples where I can test this out) - further there is
comments that I'd like to share on #1/2
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2013-05-17 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 16:49 [U-Boot] [PATCH v02 0/2] OMAP3+: introduce generic Adaptive Body Bias Support Andrii Tseglytskyi
2013-05-13 16:49 ` [U-Boot] [PATCH v02 1/2] OMAP3+: introduce generic ABB support Andrii Tseglytskyi
2013-05-17 13:11 ` Nishanth Menon
2013-05-20 11:06 ` Andrii Tseglytskyi
2013-05-20 13:51 ` Nishanth Menon
2013-05-13 16:49 ` [U-Boot] [PATCH v02 2/2] OMAP5: add ABB setup for MPU voltage domain Andrii Tseglytskyi
2013-05-17 13:01 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517130112.GA4892@kahuna \
--to=nm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.