From: Mike Crowe <mac@mcrowe.com>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] describe: Add --left-only option
Date: Fri, 17 May 2013 16:16:23 +0100 [thread overview]
Message-ID: <20130517151623.GA3083@mcrowe.com> (raw)
In-Reply-To: <20130517150329.GA27005@serenity.lan>
On Fri, May 17, 2013 at 04:03:29PM +0100, John Keeping wrote:
> On Fri, May 17, 2013 at 03:24:26PM +0100, Mike Crowe wrote:
> > Only consider the first parent commit when walking the commit history. This
> > is useful if you only wish to match tags on your branch after a merge.
>
> For consistency with "git log" should this be called "--first-parent"?
>
> In "git log" --left-only takes effect only when considering a symmetric
> range, which "git describe" isn't. Whereas --first-parent triggers
> precisely the behaviour described here.
I think you're right.
I'm happy to rename it and resubmit if the rest of the patch passes muster.
Thanks.
Mike.
prev parent reply other threads:[~2013-05-17 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 14:24 [PATCH] describe: Add --left-only option Mike Crowe
2013-05-17 15:03 ` John Keeping
2013-05-17 15:16 ` Mike Crowe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517151623.GA3083@mcrowe.com \
--to=mac@mcrowe.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.