From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Sat, 18 May 2013 19:46:44 +0200 Subject: [RFC 4/4] DRM: tda998x: add missing include In-Reply-To: <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> References: <20130516192510.GV18614@n2100.arm.linux.org.uk> <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com> <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> Message-ID: <20130518194644.2a02a4fc@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 18 May 2013 19:12:19 +0200 Sebastian Hesselbarth wrote: > The RFC sent by Russell King was missing an include for tda998x. This > is just a compatible clone to remember Russell to add that later. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: linux-arm-kernel at lists.infradead.org > Cc: dri-devel at lists.freedesktop.org > Cc: Jason Cooper > Cc: Jean-Francois Moine > --- > include/drm/i2c/tda998x.h | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 include/drm/i2c/tda998x.h > > diff --git a/include/drm/i2c/tda998x.h b/include/drm/i2c/tda998x.h > new file mode 100644 > index 0000000..41f799f > --- /dev/null > +++ b/include/drm/i2c/tda998x.h > @@ -0,0 +1,23 @@ > +#ifndef __TDA998X_H__ > +#define __TDA998X_H__ > + > +enum tda998x_audio_format { > + AFMT_I2S, > + AFMT_SPDIF, > +}; > + > +struct tda998x_encoder_params { > + int audio_cfg; > + int audio_clk_cfg; > + enum tda998x_audio_format audio_format; > + int audio_sample_rate; > + char audio_frame[6]; > + int swap_a, mirr_a; > + int swap_b, mirr_b; > + int swap_c, mirr_c; > + int swap_d, mirr_d; > + int swap_e, mirr_e; > + int swap_f, mirr_f; > +}; > + > +#endif These parameters should not be there. It seems to me that the DT is the right place. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [RFC 4/4] DRM: tda998x: add missing include Date: Sat, 18 May 2013 19:46:44 +0200 Message-ID: <20130518194644.2a02a4fc@armhf> References: <20130516192510.GV18614@n2100.arm.linux.org.uk> <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com> <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sebastian Hesselbarth Cc: Russell King , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Jason Cooper List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAxOCBNYXkgMjAxMyAxOToxMjoxOSArMDIwMApTZWJhc3RpYW4gSGVzc2VsYmFydGgg PHNlYmFzdGlhbi5oZXNzZWxiYXJ0aEBnbWFpbC5jb20+IHdyb3RlOgoKPiBUaGUgUkZDIHNlbnQg YnkgUnVzc2VsbCBLaW5nIHdhcyBtaXNzaW5nIGFuIGluY2x1ZGUgZm9yIHRkYTk5OHguIFRoaXMK PiBpcyBqdXN0IGEgY29tcGF0aWJsZSBjbG9uZSB0byByZW1lbWJlciBSdXNzZWxsIHRvIGFkZCB0 aGF0IGxhdGVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFNlYmFzdGlhbiBIZXNzZWxiYXJ0aCA8c2Vi YXN0aWFuLmhlc3NlbGJhcnRoQGdtYWlsLmNvbT4KPiAtLS0KPiBDYzogUnVzc2VsbCBLaW5nIDxs aW51eEBhcm0ubGludXgub3JnLnVrPgo+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBKYXNv biBDb29wZXIgPGphc29uQGxha2VkYWVtb24ubmV0Pgo+IENjOiBKZWFuLUZyYW5jb2lzIE1vaW5l IDxtb2luZWpmQGZyZWUuZnI+Cj4gLS0tCj4gIGluY2x1ZGUvZHJtL2kyYy90ZGE5OTh4LmggfCAg IDIzICsrKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRp b25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2RybS9pMmMvdGRhOTk4eC5oCj4g Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2kyYy90ZGE5OTh4LmggYi9pbmNsdWRlL2RybS9p MmMvdGRhOTk4eC5oCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwLi40MWY3 OTlmCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2luY2x1ZGUvZHJtL2kyYy90ZGE5OTh4LmgKPiBA QCAtMCwwICsxLDIzIEBACj4gKyNpZm5kZWYgX19UREE5OThYX0hfXwo+ICsjZGVmaW5lIF9fVERB OTk4WF9IX18KPiArCj4gK2VudW0gdGRhOTk4eF9hdWRpb19mb3JtYXQgewo+ICsJQUZNVF9JMlMs Cj4gKwlBRk1UX1NQRElGLAo+ICt9Owo+ICsKPiArc3RydWN0IHRkYTk5OHhfZW5jb2Rlcl9wYXJh bXMgewo+ICsJaW50IGF1ZGlvX2NmZzsKPiArCWludCBhdWRpb19jbGtfY2ZnOwo+ICsJZW51bSB0 ZGE5OTh4X2F1ZGlvX2Zvcm1hdCBhdWRpb19mb3JtYXQ7Cj4gKwlpbnQgYXVkaW9fc2FtcGxlX3Jh dGU7Cj4gKwljaGFyIGF1ZGlvX2ZyYW1lWzZdOwo+ICsJaW50IHN3YXBfYSwgbWlycl9hOwo+ICsJ aW50IHN3YXBfYiwgbWlycl9iOwo+ICsJaW50IHN3YXBfYywgbWlycl9jOwo+ICsJaW50IHN3YXBf ZCwgbWlycl9kOwo+ICsJaW50IHN3YXBfZSwgbWlycl9lOwo+ICsJaW50IHN3YXBfZiwgbWlycl9m Owo+ICt9Owo+ICsKPiArI2VuZGlmCgpUaGVzZSBwYXJhbWV0ZXJzIHNob3VsZCBub3QgYmUgdGhl cmUuIEl0IHNlZW1zIHRvIG1lIHRoYXQgdGhlIERUIGlzIHRoZQpyaWdodCBwbGFjZS4KCi0tIApL ZW4gYXIgYydoZW50YcOxCXwJICAgICAgKiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJ fAkJaHR0cDovL21vaW5lamYuZnJlZS5mci8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK