From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Sat, 18 May 2013 20:58:45 +0200 Subject: [RFC 4/4] DRM: tda998x: add missing include In-Reply-To: References: <20130516192510.GV18614@n2100.arm.linux.org.uk> <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com> <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> <20130518194644.2a02a4fc@armhf> Message-ID: <20130518205845.2dfe9fe5@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 18 May 2013 14:23:19 -0400 Rob Clark wrote: > > These parameters should not be there. It seems to me that the DT is the > > right place. > > You might not want to directly have a hard DT dependency in tda998x, > as the encoder could be used on non-DT platforms. Although a DT to > encoder-params helper might be a nice idea for platforms which do have > DT. If I correctly understand: - Russell does not use any DT, so his drm driver should be declared in some cubox-setup code in mach-dove/ - this code should also declare the tda998x - the drm driver contains/passes parameters to the tda998x As the connection Dove LCD <-> tda998x is Cubox specific, the question is: why are'nt the tda998x parameters in the cubox-setup code? -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [RFC 4/4] DRM: tda998x: add missing include Date: Sat, 18 May 2013 20:58:45 +0200 Message-ID: <20130518205845.2dfe9fe5@armhf> References: <20130516192510.GV18614@n2100.arm.linux.org.uk> <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com> <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> <20130518194644.2a02a4fc@armhf> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Clark Cc: Jason Cooper , Russell King , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Sebastian Hesselbarth List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAxOCBNYXkgMjAxMyAxNDoyMzoxOSAtMDQwMApSb2IgQ2xhcmsgPHJvYmRjbGFya0Bn bWFpbC5jb20+IHdyb3RlOgoKPiA+IFRoZXNlIHBhcmFtZXRlcnMgc2hvdWxkIG5vdCBiZSB0aGVy ZS4gSXQgc2VlbXMgdG8gbWUgdGhhdCB0aGUgRFQgaXMgdGhlCj4gPiByaWdodCBwbGFjZS4gIAo+ IAo+IFlvdSBtaWdodCBub3Qgd2FudCB0byBkaXJlY3RseSBoYXZlIGEgaGFyZCBEVCBkZXBlbmRl bmN5IGluIHRkYTk5OHgsCj4gYXMgdGhlIGVuY29kZXIgY291bGQgYmUgdXNlZCBvbiBub24tRFQg cGxhdGZvcm1zLiAgQWx0aG91Z2ggYSBEVCB0bwo+IGVuY29kZXItcGFyYW1zIGhlbHBlciBtaWdo dCBiZSBhIG5pY2UgaWRlYSBmb3IgcGxhdGZvcm1zIHdoaWNoIGRvIGhhdmUKPiBEVC4KCklmIEkg Y29ycmVjdGx5IHVuZGVyc3RhbmQ6CgotIFJ1c3NlbGwgZG9lcyBub3QgdXNlIGFueSBEVCwgc28g aGlzIGRybSBkcml2ZXIgc2hvdWxkIGJlIGRlY2xhcmVkIGluCiAgc29tZSBjdWJveC1zZXR1cCBj b2RlIGluIG1hY2gtZG92ZS8KCi0gdGhpcyBjb2RlIHNob3VsZCBhbHNvIGRlY2xhcmUgdGhlIHRk YTk5OHgKCi0gdGhlIGRybSBkcml2ZXIgY29udGFpbnMvcGFzc2VzIHBhcmFtZXRlcnMgdG8gdGhl IHRkYTk5OHgKCkFzIHRoZSBjb25uZWN0aW9uIERvdmUgTENEIDwtPiB0ZGE5OTh4IGlzIEN1Ym94 IHNwZWNpZmljLCB0aGUgcXVlc3Rpb24KaXM6IHdoeSBhcmUnbnQgdGhlIHRkYTk5OHggcGFyYW1l dGVycyBpbiB0aGUgY3Vib3gtc2V0dXAgY29kZT8KCi0tIApLZW4gYXIgYydoZW50YcOxCXwJICAg ICAgKiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJfAkJaHR0cDovL21vaW5lamYuZnJl ZS5mci8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK