Re: [PATCH] qt4: remove trailing slash from prefix

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1646 bytes --]

On Wed, May 08, 2013 at 09:14:16PM +0200, Martin Jansa wrote:
> On Wed, May 08, 2013 at 07:07:57PM +0100, Paul Barker wrote:
> > On 7 May 2013 10:05, Paul Barker <paul@paulbarker.me.uk> wrote:
> > > The trailing slashs on "Prefix=${prefix}/" and "-prefix ${prefix}/" are passed
> > > through to the generated pkgconfig files and may be joined to paths like
> > > "/include" yielding a final path with a double forward-slash (eg.
> > > "/usr//include"). This may end up in the debugging symbols in other applications
> > > or libraries which depend on qt4 which in turn causes the debugedit program to
> > > fail with the message "canonicalization unexpectedly shrank by one character"
> > > when it tries to replace the double forward-slash with a single forward-slash.
> > > Thus the function split_and_strip_files fails and ultimately do_package fails.
> > >
> > > As this slash is removed from the prefix it is added into the regular expression
> > > used to fix up pkgconfig files later in the recipe.
> > >
> > > This error was seen in vlc in meta-openembedded and should be solved by this
> > > change in openembedded-core.
> > >
> > > Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> > 
> > Martin, could you check whether applying this patch to oe-core fixes
> > the vlc do_package failure you were seeing?
> 
> Yes I plan to include it in next build, but I would like to fix
> webkit-efl build with newer binutils first, because that adds 3.9M lines 
> from log.do_compile and resulting logs from world have 600M :/

Yes it fixed it, thanks!

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]