From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Sun, 19 May 2013 08:01:52 +0200 Subject: [RFC 4/4] DRM: tda998x: add missing include In-Reply-To: <5197D6C1.3060702@gmail.com> References: <20130516192510.GV18614@n2100.arm.linux.org.uk> <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com> <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> <20130518194644.2a02a4fc@armhf> <20130518205845.2dfe9fe5@armhf> <5197D6C1.3060702@gmail.com> Message-ID: <20130519080152.0b486b75@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 18 May 2013 21:30:09 +0200 Sebastian Hesselbarth wrote: > So in the end, we will have a DT node for the HW controllers found > in Dove SoCs, a node for TDA998x, and a node for the video card, i.e. > _how_ lcd controllers, external encoders, clocks, maybe audio, ... > are hooked up on that specific board. Here is my dove-cubox.dts. What is wrong with it? /dts-v1/; /include/ "dove.dtsi" / { model = "SolidRun CuBox"; compatible = "solidrun,cubox", "marvell,dove"; memory { device_type = "memory"; reg = <0x00000000 0x40000000>; }; chosen { bootargs = "console=ttyS0,115200n8 earlyprintk"; }; leds { compatible = "gpio-leds"; pinctrl-0 = <&pmx_gpio_18>; pinctrl-names = "default"; power { label = "Power"; gpios = <&gpio0 18 1>; linux,default-trigger = "default-on"; }; }; regulators { compatible = "simple-bus"; #address-cells = <1>; #size-cells = <0>; usb_power: regulator at 1 { compatible = "regulator-fixed"; reg = <1>; regulator-name = "USB Power"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; enable-active-high; regulator-always-on; regulator-boot-on; gpio = <&gpio0 1 0>; }; }; clocks { /* 25MHz reference crystal */ ref25: oscillator { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <25000000>; }; lcdclk: fixed-clock { compatible = "fixed-clock"; #clock-cells = <0>; clock-frequency = <400000000>; }; }; audio { compatible = "marvell,kirkwood-spdif-audio"; id = <1>; }; video { compatible = "marvell,dove-video"; }; }; &uart0 { status = "okay"; }; &sata0 { status = "okay"; }; &i2c0 { status = "okay"; clock-frequency = <100000>; si5351: clock-generator { compatible = "silabs,si5351a-msop"; reg = <0x60>; #address-cells = <1>; #size-cells = <0>; #clock-cells = <1>; /* connect xtal input to 25MHz reference */ clocks = <&ref25>; /* connect xtal input as source of pll0 and pll1 */ silabs,pll-source = <0 0>, <1 0>; clkout0 { reg = <0>; silabs,drive-strength = <8>; silabs,multisynth-source = <0>; silabs,clock-source = <0>; silabs,pll-master; }; clkout1 { reg = <1>; silabs,drive-strength = <8>; silabs,multisynth-source = <1>; silabs,clock-source = <0>; silabs,pll-master; }; clkout2 { reg = <2>; silabs,multisynth-source = <1>; silabs,clock-source = <0>; }; }; tda998x: hdmi-encoder { compatible = "nxp,tda998x"; reg = <0x70>; interrupt-parent = <&gpio0>; interrupts = <27 2>; /* falling edge */ }; }; &sdio0 { status = "okay"; /* sdio0 card detect is connected to wrong pin on CuBox */ cd-gpios = <&gpio0 12 1>; }; &spi0 { status = "okay"; /* spi0.0: 4M Flash Winbond W25Q32BV */ spi-flash at 0 { compatible = "st,w25q32"; spi-max-frequency = <20000000>; reg = <0>; }; }; &pinctrl { pinctrl-0 = <&pmx_gpio_1 &pmx_gpio_12 &pmx_gpio_13 &pmx_gpio_camera>; pinctrl-names = "default"; pmx_gpio_1: pmx-gpio-1 { marvell,pins = "mpp1"; marvell,function = "gpio"; }; pmx_gpio_12: pmx-gpio-12 { marvell,pins = "mpp12"; marvell,function = "gpio"; }; /* kirkwood i2s */ pmx_gpio_13: pmx-gpio-13 { marvell,pins = "mpp13"; marvell,function = "gpio"; }; pmx_gpio_18: pmx-gpio-18 { marvell,pins = "mpp18"; marvell,function = "gpio"; }; /* nxp HDMI irq on pin 27 */ pmx_gpio_camera: pmx-gpio-camera { marvell,pins = "mpp_camera"; marvell,function = "gpio"; }; }; &mdio { status = "okay"; }; ðernet { status = "okay"; }; &lcd0 { status = "okay"; clocks = <&core_clk 3>, <0>, <&lcdclk>, <&si5351 0>; marvell,port-type = <11>; /* HDMIA */ marvell,external-encoder = <&tda998x>; }; &i2s1 { status = "okay"; }; /* --- test (not cubox) ---- * &dcon { status = "okay"; }; &lcd1 { status = "okay"; clocks = <&core_clk 3>, <0>, <&lcdclk>, <0>; marvell,port-type = <1>; display-timings { mode { hactive = <1920>; vactive = <1080>; hfront-porch = <88>; hsync-len = <44>; hback-porch = <148>; vfront-porch = <4>; vsync-len = <5>; vback-porch = <36>; clock = <148500>; }; }; }; * ---- */ -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [RFC 4/4] DRM: tda998x: add missing include Date: Sun, 19 May 2013 08:01:52 +0200 Message-ID: <20130519080152.0b486b75@armhf> References: <20130516192510.GV18614@n2100.arm.linux.org.uk> <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com> <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> <20130518194644.2a02a4fc@armhf> <20130518205845.2dfe9fe5@armhf> <5197D6C1.3060702@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5197D6C1.3060702@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sebastian Hesselbarth Cc: Rob Clark , Russell King , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Jason Cooper List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAxOCBNYXkgMjAxMyAyMTozMDowOSArMDIwMApTZWJhc3RpYW4gSGVzc2VsYmFydGgg PHNlYmFzdGlhbi5oZXNzZWxiYXJ0aEBnbWFpbC5jb20+IHdyb3RlOgoKPiBTbyBpbiB0aGUgZW5k LCB3ZSB3aWxsIGhhdmUgYSBEVCBub2RlIGZvciB0aGUgSFcgY29udHJvbGxlcnMgZm91bmQKPiBp biBEb3ZlIFNvQ3MsIGEgbm9kZSBmb3IgVERBOTk4eCwgYW5kIGEgbm9kZSBmb3IgdGhlIHZpZGVv IGNhcmQsIGkuZS4KPiBfaG93XyBsY2QgY29udHJvbGxlcnMsIGV4dGVybmFsIGVuY29kZXJzLCBj bG9ja3MsIG1heWJlIGF1ZGlvLCAuLi4KPiBhcmUgaG9va2VkIHVwIG9uIHRoYXQgc3BlY2lmaWMg Ym9hcmQuCgpIZXJlIGlzIG15IGRvdmUtY3Vib3guZHRzLiBXaGF0IGlzIHdyb25nIHdpdGggaXQ/ CgovZHRzLXYxLzsKCi9pbmNsdWRlLyAiZG92ZS5kdHNpIgoKLyB7Cgltb2RlbCA9ICJTb2xpZFJ1 biBDdUJveCI7Cgljb21wYXRpYmxlID0gInNvbGlkcnVuLGN1Ym94IiwgIm1hcnZlbGwsZG92ZSI7 CgoJbWVtb3J5IHsKCQlkZXZpY2VfdHlwZSA9ICJtZW1vcnkiOwoJCXJlZyA9IDwweDAwMDAwMDAw IDB4NDAwMDAwMDA+OwoJfTsKCgljaG9zZW4gewoJCWJvb3RhcmdzID0gImNvbnNvbGU9dHR5UzAs MTE1MjAwbjggZWFybHlwcmludGsiOwoJfTsKCglsZWRzIHsKCQljb21wYXRpYmxlID0gImdwaW8t bGVkcyI7CgkJcGluY3RybC0wID0gPCZwbXhfZ3Bpb18xOD47CgkJcGluY3RybC1uYW1lcyA9ICJk ZWZhdWx0IjsKCgkJcG93ZXIgewoJCQlsYWJlbCA9ICJQb3dlciI7CgkJCWdwaW9zID0gPCZncGlv MCAxOCAxPjsKCQkJbGludXgsZGVmYXVsdC10cmlnZ2VyID0gImRlZmF1bHQtb24iOwoJCX07Cgl9 OwoKCXJlZ3VsYXRvcnMgewoJCWNvbXBhdGlibGUgPSAic2ltcGxlLWJ1cyI7CgkJI2FkZHJlc3Mt Y2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgoJCXVzYl9wb3dlcjogcmVndWxhdG9y QDEgewoJCQljb21wYXRpYmxlID0gInJlZ3VsYXRvci1maXhlZCI7CgkJCXJlZyA9IDwxPjsKCQkJ cmVndWxhdG9yLW5hbWUgPSAiVVNCIFBvd2VyIjsKCQkJcmVndWxhdG9yLW1pbi1taWNyb3ZvbHQg PSA8NTAwMDAwMD47CgkJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDUwMDAwMDA+OwoJCQll bmFibGUtYWN0aXZlLWhpZ2g7CgkJCXJlZ3VsYXRvci1hbHdheXMtb247CgkJCXJlZ3VsYXRvci1i b290LW9uOwoJCQlncGlvID0gPCZncGlvMCAxIDA+OwoJCX07Cgl9OwoKCWNsb2NrcyB7CgkJLyog MjVNSHogcmVmZXJlbmNlIGNyeXN0YWwgKi8KCQlyZWYyNTogb3NjaWxsYXRvciB7CgkJCWNvbXBh dGlibGUgPSAiZml4ZWQtY2xvY2siOwoJCQkjY2xvY2stY2VsbHMgPSA8MD47CgkJCWNsb2NrLWZy ZXF1ZW5jeSA9IDwyNTAwMDAwMD47CgkJfTsKCgkJbGNkY2xrOiBmaXhlZC1jbG9jayB7CgkJCWNv bXBhdGlibGUgPSAiZml4ZWQtY2xvY2siOwoJCQkjY2xvY2stY2VsbHMgPSA8MD47CgkJCWNsb2Nr LWZyZXF1ZW5jeSA9IDw0MDAwMDAwMDA+OwoJCX07Cgl9OwoKCWF1ZGlvIHsKCQljb21wYXRpYmxl ID0gIm1hcnZlbGwsa2lya3dvb2Qtc3BkaWYtYXVkaW8iOwoJCWlkID0gPDE+OwoJfTsKCgl2aWRl byB7CgkJY29tcGF0aWJsZSA9ICJtYXJ2ZWxsLGRvdmUtdmlkZW8iOwoJfTsKfTsKCiZ1YXJ0MCB7 IHN0YXR1cyA9ICJva2F5IjsgfTsKJnNhdGEwIHsgc3RhdHVzID0gIm9rYXkiOyB9OwomaTJjMCB7 CglzdGF0dXMgPSAib2theSI7CgljbG9jay1mcmVxdWVuY3kgPSA8MTAwMDAwPjsKCglzaTUzNTE6 IGNsb2NrLWdlbmVyYXRvciB7CgkJY29tcGF0aWJsZSA9ICJzaWxhYnMsc2k1MzUxYS1tc29wIjsK CQlyZWcgPSA8MHg2MD47CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8 MD47CgkJI2Nsb2NrLWNlbGxzID0gPDE+OwoKCQkvKiBjb25uZWN0IHh0YWwgaW5wdXQgdG8gMjVN SHogcmVmZXJlbmNlICovCgkJY2xvY2tzID0gPCZyZWYyNT47CgoJCS8qIGNvbm5lY3QgeHRhbCBp bnB1dCBhcyBzb3VyY2Ugb2YgcGxsMCBhbmQgcGxsMSAqLwoJCXNpbGFicyxwbGwtc291cmNlID0g PDAgMD4sIDwxIDA+OwoKCQljbGtvdXQwIHsKCQkJcmVnID0gPDA+OwoJCQlzaWxhYnMsZHJpdmUt c3RyZW5ndGggPSA8OD47CgkJCXNpbGFicyxtdWx0aXN5bnRoLXNvdXJjZSA9IDwwPjsKCQkJc2ls YWJzLGNsb2NrLXNvdXJjZSA9IDwwPjsKCQkJc2lsYWJzLHBsbC1tYXN0ZXI7CgkJfTsKCgkJY2xr b3V0MSB7CgkJCXJlZyA9IDwxPjsKCQkJc2lsYWJzLGRyaXZlLXN0cmVuZ3RoID0gPDg+OwoJCQlz aWxhYnMsbXVsdGlzeW50aC1zb3VyY2UgPSA8MT47CgkJCXNpbGFicyxjbG9jay1zb3VyY2UgPSA8 MD47CgkJCXNpbGFicyxwbGwtbWFzdGVyOwoJCX07CgoJCWNsa291dDIgewoJCQlyZWcgPSA8Mj47 CgkJCXNpbGFicyxtdWx0aXN5bnRoLXNvdXJjZSA9IDwxPjsKCQkJc2lsYWJzLGNsb2NrLXNvdXJj ZSA9IDwwPjsKCQl9OwoJfTsKCgl0ZGE5OTh4OiBoZG1pLWVuY29kZXIgewoJCWNvbXBhdGlibGUg PSAibnhwLHRkYTk5OHgiOwoJCXJlZyA9IDwweDcwPjsKCQlpbnRlcnJ1cHQtcGFyZW50ID0gPCZn cGlvMD47CgkJaW50ZXJydXB0cyA9IDwyNyAyPjsJCS8qIGZhbGxpbmcgZWRnZSAqLwoJfTsKfTsK CiZzZGlvMCB7CglzdGF0dXMgPSAib2theSI7CgkvKiBzZGlvMCBjYXJkIGRldGVjdCBpcyBjb25u ZWN0ZWQgdG8gd3JvbmcgcGluIG9uIEN1Qm94ICovCgljZC1ncGlvcyA9IDwmZ3BpbzAgMTIgMT47 Cn07Cgomc3BpMCB7CglzdGF0dXMgPSAib2theSI7CgoJLyogc3BpMC4wOiA0TSBGbGFzaCBXaW5i b25kIFcyNVEzMkJWICovCglzcGktZmxhc2hAMCB7CgkJY29tcGF0aWJsZSA9ICJzdCx3MjVxMzIi OwoJCXNwaS1tYXgtZnJlcXVlbmN5ID0gPDIwMDAwMDAwPjsKCQlyZWcgPSA8MD47Cgl9Owp9OwoK JnBpbmN0cmwgewoJcGluY3RybC0wID0gPCZwbXhfZ3Bpb18xICZwbXhfZ3Bpb18xMiAmcG14X2dw aW9fMTMgJnBteF9ncGlvX2NhbWVyYT47CglwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoKCXBt eF9ncGlvXzE6IHBteC1ncGlvLTEgewoJCW1hcnZlbGwscGlucyA9ICJtcHAxIjsKCQltYXJ2ZWxs LGZ1bmN0aW9uID0gImdwaW8iOwoJfTsKCglwbXhfZ3Bpb18xMjogcG14LWdwaW8tMTIgewoJCW1h cnZlbGwscGlucyA9ICJtcHAxMiI7CgkJbWFydmVsbCxmdW5jdGlvbiA9ICJncGlvIjsKCX07Cgov KiBraXJrd29vZCBpMnMgKi8KCXBteF9ncGlvXzEzOiBwbXgtZ3Bpby0xMyB7CgkJbWFydmVsbCxw aW5zID0gIm1wcDEzIjsKCQltYXJ2ZWxsLGZ1bmN0aW9uID0gImdwaW8iOwoJfTsKCglwbXhfZ3Bp b18xODogcG14LWdwaW8tMTggewoJCW1hcnZlbGwscGlucyA9ICJtcHAxOCI7CgkJbWFydmVsbCxm dW5jdGlvbiA9ICJncGlvIjsKCX07Ci8qIG54cCBIRE1JIGlycSBvbiBwaW4gMjcgKi8KCXBteF9n cGlvX2NhbWVyYTogcG14LWdwaW8tY2FtZXJhIHsKCQltYXJ2ZWxsLHBpbnMgPSAibXBwX2NhbWVy YSI7CgkJbWFydmVsbCxmdW5jdGlvbiA9ICJncGlvIjsKCX07Cn07CgombWRpbyB7IHN0YXR1cyA9 ICJva2F5IjsgfTsKJmV0aGVybmV0IHsgc3RhdHVzID0gIm9rYXkiOyB9OwombGNkMCB7CglzdGF0 dXMgPSAib2theSI7CgljbG9ja3MgPSA8JmNvcmVfY2xrIDM+LCA8MD4sIDwmbGNkY2xrPiwgPCZz aTUzNTEgMD47CgltYXJ2ZWxsLHBvcnQtdHlwZSA9IDwxMT47CQkvKiBIRE1JQSAqLwoJbWFydmVs bCxleHRlcm5hbC1lbmNvZGVyID0gPCZ0ZGE5OTh4PjsKfTsKCiZpMnMxIHsgc3RhdHVzID0gIm9r YXkiOyB9OwoKLyogLS0tIHRlc3QgKG5vdCBjdWJveCkgLS0tLSAqCiZkY29uIHsgc3RhdHVzID0g Im9rYXkiOyB9OwoKJmxjZDEgewoJc3RhdHVzID0gIm9rYXkiOwoJY2xvY2tzID0gPCZjb3JlX2Ns ayAzPiwgPDA+LCA8JmxjZGNsaz4sIDwwPjsKCW1hcnZlbGwscG9ydC10eXBlID0gPDE+OwoJZGlz cGxheS10aW1pbmdzIHsKCQltb2RlIHsKCQkJaGFjdGl2ZSA9IDwxOTIwPjsKCQkJdmFjdGl2ZSA9 IDwxMDgwPjsKCQkJaGZyb250LXBvcmNoID0gPDg4PjsKCQkJaHN5bmMtbGVuID0gPDQ0PjsKCQkJ aGJhY2stcG9yY2ggPSA8MTQ4PjsKCQkJdmZyb250LXBvcmNoID0gPDQ+OwoJCQl2c3luYy1sZW4g PSA8NT47CgkJCXZiYWNrLXBvcmNoID0gPDM2PjsKCQkJY2xvY2sgPSA8MTQ4NTAwPjsKCQl9OwoJ fTsKfTsKICogLS0tLSAqLwoKLS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAgICAqKiBCcmVpemgg aGEgTGludXggYXRhdiEgKioKSmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVlLmZyLwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=