Re: [PATCH] of: add ranges address translation for default bus

[Sascha Hauer <s.hauer@pengutronix.de>]

On Sun, May 19, 2013 at 10:07:26AM +0200, Sebastian Hesselbarth wrote:
> On 05/19/2013 09:34 AM, Sascha Hauer wrote:
> >Hi Sebastian,
> >
> >On Mon, May 13, 2013 at 01:09:06AM +0200, Sebastian Hesselbarth wrote:
> >>This patch adds address translation for default bus types. It has been
> >>shamelessly ported from Linux device tree address translation with the
> >>following exceptions:
> >>- only default bus map and translate are supported
> >>- of_bus has not been ported
> >>- check for #size-cells>  0 has been removed
> >>
> >>Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com>
> >
> >I just gave this one a test.
> >
> >First of all you dropped 1:1 translation, see the attached fixup.
> 
> Sascha,
> 
> I know I dropped it, but have you tried empty/bool properties?
> I had no luck with an empty/bool ranges, so I removed the 1:1
> translation by empty property and wanted to take a look at bool
> props first.

Probably because of_get_property doesn't seem to be 100% Linux
compatible. Our version returns NULL for empty properties whereas
the Linux version seems to return some valid pointer for zero length
properties.

I used of_find_property instead in my fixup, but maybe it's better
to change the behaviour of of_get_property instead.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox