From: gleb@redhat.com (Gleb Natapov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] ARM: KVM: Moving GIC/timer out of arch/arm
Date: Sun, 19 May 2013 15:14:38 +0300 [thread overview]
Message-ID: <20130519121438.GG4725@redhat.com> (raw)
In-Reply-To: <1368538262-25546-1-git-send-email-marc.zyngier@arm.com>
On Tue, May 14, 2013 at 02:31:00PM +0100, Marc Zyngier wrote:
> As KVM/arm64 is looming on the horizon, it makes sense to move some
> of the common code to a single location in order to reduce duplication.
>
> The code could live anywhere. Actually, most of KVM is already built
> with a bunch of ugly ../../.. hacks in the various Makefiles, so we're
> not exactly talking about style here. But maybe it is time to start
> moving into a less ugly direction.
>
> The include files must be in a "public" location, as they are accessed
> from non-KVM files (arch/arm/kernel/asm-offsets.c).
>
> For this purpose, introduce two new locations:
> - virt/kvm/arm/ : x86 and ia64 already share the ioapic code in
> virt/kvm, so this could be seen as a (very ugly) precedent.
> - include/kvm/ : there is already an include/xen, and while the
> intent is slightly different, this seems as good a location as
> any
>
> A second, tree-wide patch also removes the use of the addprefix used
> to refer to the main KVM code from the arch code, and replace it with
> a KVM variable that does the same thing.
>
> * From v2:
> - Fix silly bug breaking compilation on x86...
>
Applied, thanks.
> Marc Zyngier (2):
> ARM: KVM: move GIC/timer code to a common location
> KVM: get rid of $(addprefix ../../../virt/kvm/, ...) in Makefiles
>
> arch/arm/include/asm/kvm_host.h | 4 ++--
> arch/arm/kvm/Makefile | 7 ++++---
> arch/ia64/kvm/Makefile | 7 ++++---
> arch/powerpc/kvm/Makefile | 13 +++++++------
> arch/s390/kvm/Makefile | 3 ++-
> arch/x86/kvm/Makefile | 13 +++++++------
> .../asm/kvm_arch_timer.h => include/kvm/arm_arch_timer.h | 0
> arch/arm/include/asm/kvm_vgic.h => include/kvm/arm_vgic.h | 0
> {arch/arm/kvm => virt/kvm/arm}/arch_timer.c | 4 ++--
> {arch/arm/kvm => virt/kvm/arm}/vgic.c | 0
> 10 files changed, 28 insertions(+), 23 deletions(-)
> rename arch/arm/include/asm/kvm_arch_timer.h => include/kvm/arm_arch_timer.h (100%)
> rename arch/arm/include/asm/kvm_vgic.h => include/kvm/arm_vgic.h (100%)
> rename {arch/arm/kvm => virt/kvm/arm}/arch_timer.c (99%)
> rename {arch/arm/kvm => virt/kvm/arm}/vgic.c (100%)
>
> --
> 1.8.2.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Gleb.
WARNING: multiple messages have this Message-ID (diff)
From: Gleb Natapov <gleb@redhat.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Subject: Re: [PATCH v3 0/2] ARM: KVM: Moving GIC/timer out of arch/arm
Date: Sun, 19 May 2013 15:14:38 +0300 [thread overview]
Message-ID: <20130519121438.GG4725@redhat.com> (raw)
In-Reply-To: <1368538262-25546-1-git-send-email-marc.zyngier@arm.com>
On Tue, May 14, 2013 at 02:31:00PM +0100, Marc Zyngier wrote:
> As KVM/arm64 is looming on the horizon, it makes sense to move some
> of the common code to a single location in order to reduce duplication.
>
> The code could live anywhere. Actually, most of KVM is already built
> with a bunch of ugly ../../.. hacks in the various Makefiles, so we're
> not exactly talking about style here. But maybe it is time to start
> moving into a less ugly direction.
>
> The include files must be in a "public" location, as they are accessed
> from non-KVM files (arch/arm/kernel/asm-offsets.c).
>
> For this purpose, introduce two new locations:
> - virt/kvm/arm/ : x86 and ia64 already share the ioapic code in
> virt/kvm, so this could be seen as a (very ugly) precedent.
> - include/kvm/ : there is already an include/xen, and while the
> intent is slightly different, this seems as good a location as
> any
>
> A second, tree-wide patch also removes the use of the addprefix used
> to refer to the main KVM code from the arch code, and replace it with
> a KVM variable that does the same thing.
>
> * From v2:
> - Fix silly bug breaking compilation on x86...
>
Applied, thanks.
> Marc Zyngier (2):
> ARM: KVM: move GIC/timer code to a common location
> KVM: get rid of $(addprefix ../../../virt/kvm/, ...) in Makefiles
>
> arch/arm/include/asm/kvm_host.h | 4 ++--
> arch/arm/kvm/Makefile | 7 ++++---
> arch/ia64/kvm/Makefile | 7 ++++---
> arch/powerpc/kvm/Makefile | 13 +++++++------
> arch/s390/kvm/Makefile | 3 ++-
> arch/x86/kvm/Makefile | 13 +++++++------
> .../asm/kvm_arch_timer.h => include/kvm/arm_arch_timer.h | 0
> arch/arm/include/asm/kvm_vgic.h => include/kvm/arm_vgic.h | 0
> {arch/arm/kvm => virt/kvm/arm}/arch_timer.c | 4 ++--
> {arch/arm/kvm => virt/kvm/arm}/vgic.c | 0
> 10 files changed, 28 insertions(+), 23 deletions(-)
> rename arch/arm/include/asm/kvm_arch_timer.h => include/kvm/arm_arch_timer.h (100%)
> rename arch/arm/include/asm/kvm_vgic.h => include/kvm/arm_vgic.h (100%)
> rename {arch/arm/kvm => virt/kvm/arm}/arch_timer.c (99%)
> rename {arch/arm/kvm => virt/kvm/arm}/vgic.c (100%)
>
> --
> 1.8.2.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Gleb.
next prev parent reply other threads:[~2013-05-19 12:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 13:31 [PATCH v3 0/2] ARM: KVM: Moving GIC/timer out of arch/arm Marc Zyngier
2013-05-14 13:31 ` Marc Zyngier
2013-05-14 13:31 ` [PATCH v3 1/2] ARM: KVM: move GIC/timer code to a common location Marc Zyngier
2013-05-14 13:31 ` Marc Zyngier
2013-05-14 13:31 ` [PATCH v3 2/2] KVM: get rid of $(addprefix ../../../virt/kvm/, ...) in Makefiles Marc Zyngier
2013-05-14 13:31 ` Marc Zyngier
2013-05-16 10:42 ` Gleb Natapov
2013-05-16 10:42 ` Gleb Natapov
2013-05-16 11:00 ` Christian Borntraeger
2013-05-16 11:00 ` Christian Borntraeger
2013-05-19 12:14 ` Gleb Natapov [this message]
2013-05-19 12:14 ` [PATCH v3 0/2] ARM: KVM: Moving GIC/timer out of arch/arm Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130519121438.GG4725@redhat.com \
--to=gleb@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.