[patch] gru: fix a sanity test in gru_set_context

All of lore.kernel.org
 help / color / mirror / Atom feed

* [patch] gru: fix a sanity test in gru_set_context_option()
@ 2013-05-19 12:59 ` Dan Carpenter
  0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2013-05-19 12:59 UTC (permalink / raw)
  To: Dimitri Sivanich; +Cc: Robin Holt, linux-kernel, kernel-janitors

"req.val1 = -1" is valid but it doesn't make sense to check
gru_base[-1].  gru_base[] is a global array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c
index c4acac7..e7c37b2 100644
--- a/drivers/misc/sgi-gru/grufault.c
+++ b/drivers/misc/sgi-gru/grufault.c
@@ -876,7 +876,8 @@ int gru_set_context_option(unsigned long arg)
 	switch (req.op) {
 	case sco_blade_chiplet:
 		/* Select blade/chiplet for GRU context */
-		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
+		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
+		    (req.val1 != -1 && !gru_base[req.val1]) ||
 		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
 			ret = -EINVAL;
 		} else {

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [patch] gru: fix a sanity test in gru_set_context_option()
@ 2013-05-19 12:59 ` Dan Carpenter
  0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2013-05-19 12:59 UTC (permalink / raw)
  To: Dimitri Sivanich; +Cc: Robin Holt, linux-kernel, kernel-janitors

"req.val1 == -1" is valid but it doesn't make sense to check
gru_base[-1].  gru_base[] is a global array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c
index c4acac7..e7c37b2 100644
--- a/drivers/misc/sgi-gru/grufault.c
+++ b/drivers/misc/sgi-gru/grufault.c
@@ -876,7 +876,8 @@ int gru_set_context_option(unsigned long arg)
 	switch (req.op) {
 	case sco_blade_chiplet:
 		/* Select blade/chiplet for GRU context */
-		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
+		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
+		    (req.val1 != -1 && !gru_base[req.val1]) ||
 		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
 			ret = -EINVAL;
 		} else {

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [patch] gru: fix a sanity test in gru_set_context_option()
  2013-05-19 12:59 ` Dan Carpenter
@ 2013-05-19 14:44   ` Dimitri Sivanich
  -1 siblings, 0 replies; 10+ messages in thread
From: Dimitri Sivanich @ 2013-05-19 14:44 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Robin Holt, linux-kernel, kernel-janitors

On Sun, May 19, 2013 at 03:59:50PM +0300, Dan Carpenter wrote:
> "req.val1 = -1" is valid but it doesn't make sense to check
> gru_base[-1].  gru_base[] is a global array.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c
> index c4acac7..e7c37b2 100644
> --- a/drivers/misc/sgi-gru/grufault.c
> +++ b/drivers/misc/sgi-gru/grufault.c
> @@ -876,7 +876,8 @@ int gru_set_context_option(unsigned long arg)
>  	switch (req.op) {
>  	case sco_blade_chiplet:
>  		/* Select blade/chiplet for GRU context */
> -		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
> +		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
> +		    (req.val1 != -1 && !gru_base[req.val1]) ||
>  		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
>  			ret = -EINVAL;
>  		} else {

Since we're here, maybe we should neaten this up a little?

Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
---
 drivers/misc/sgi-gru/grufault.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux/drivers/misc/sgi-gru/grufault.c
=================================--- linux.orig/drivers/misc/sgi-gru/grufault.c
+++ linux/drivers/misc/sgi-gru/grufault.c
@@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
 	switch (req.op) {
 	case sco_blade_chiplet:
 		/* Select blade/chiplet for GRU context */
-		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
-		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
+		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
+			req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
+			(req.val1 >= 0 && !gru_base[req.val1])) {
 			ret = -EINVAL;
 		} else {
 			gts->ts_user_blade_id = req.val1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [patch] gru: fix a sanity test in gru_set_context_option()
@ 2013-05-19 14:44   ` Dimitri Sivanich
  0 siblings, 0 replies; 10+ messages in thread
From: Dimitri Sivanich @ 2013-05-19 14:44 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Robin Holt, linux-kernel, kernel-janitors

On Sun, May 19, 2013 at 03:59:50PM +0300, Dan Carpenter wrote:
> "req.val1 == -1" is valid but it doesn't make sense to check
> gru_base[-1].  gru_base[] is a global array.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/misc/sgi-gru/grufault.c b/drivers/misc/sgi-gru/grufault.c
> index c4acac7..e7c37b2 100644
> --- a/drivers/misc/sgi-gru/grufault.c
> +++ b/drivers/misc/sgi-gru/grufault.c
> @@ -876,7 +876,8 @@ int gru_set_context_option(unsigned long arg)
>  	switch (req.op) {
>  	case sco_blade_chiplet:
>  		/* Select blade/chiplet for GRU context */
> -		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
> +		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
> +		    (req.val1 != -1 && !gru_base[req.val1]) ||
>  		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
>  			ret = -EINVAL;
>  		} else {

Since we're here, maybe we should neaten this up a little?

Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
---
 drivers/misc/sgi-gru/grufault.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux/drivers/misc/sgi-gru/grufault.c
===================================================================
--- linux.orig/drivers/misc/sgi-gru/grufault.c
+++ linux/drivers/misc/sgi-gru/grufault.c
@@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
 	switch (req.op) {
 	case sco_blade_chiplet:
 		/* Select blade/chiplet for GRU context */
-		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
-		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
+		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
+			req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
+			(req.val1 >= 0 && !gru_base[req.val1])) {
 			ret = -EINVAL;
 		} else {
 			gts->ts_user_blade_id = req.val1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [patch] gru: fix a sanity test in gru_set_context_option()
  2013-05-19 14:44   ` Dimitri Sivanich
@ 2013-05-19 18:30     ` Dan Carpenter
  -1 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2013-05-19 18:30 UTC (permalink / raw)
  To: Dimitri Sivanich; +Cc: Robin Holt, linux-kernel, kernel-janitors

On Sun, May 19, 2013 at 09:44:42AM -0500, Dimitri Sivanich wrote:
> 
> Since we're here, maybe we should neaten this up a little?
> 
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> ---
>  drivers/misc/sgi-gru/grufault.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux/drivers/misc/sgi-gru/grufault.c
> =================================> --- linux.orig/drivers/misc/sgi-gru/grufault.c
> +++ linux/drivers/misc/sgi-gru/grufault.c
> @@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
>  	switch (req.op) {
>  	case sco_blade_chiplet:
>  		/* Select blade/chiplet for GRU context */
> -		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
> -		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
> +		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
> +			req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
> +			(req.val1 >= 0 && !gru_base[req.val1])) {
>  			ret = -EINVAL;

I generally prefer how in the original code all the sub conditions
were aligned nicely but I will Ack your version as well.  Thanks.

regards,
dan carpenter

>  		} else {
>  			gts->ts_user_blade_id = req.val1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [patch] gru: fix a sanity test in gru_set_context_option()
@ 2013-05-19 18:30     ` Dan Carpenter
  0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2013-05-19 18:30 UTC (permalink / raw)
  To: Dimitri Sivanich; +Cc: Robin Holt, linux-kernel, kernel-janitors

On Sun, May 19, 2013 at 09:44:42AM -0500, Dimitri Sivanich wrote:
> 
> Since we're here, maybe we should neaten this up a little?
> 
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> ---
>  drivers/misc/sgi-gru/grufault.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux/drivers/misc/sgi-gru/grufault.c
> ===================================================================
> --- linux.orig/drivers/misc/sgi-gru/grufault.c
> +++ linux/drivers/misc/sgi-gru/grufault.c
> @@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
>  	switch (req.op) {
>  	case sco_blade_chiplet:
>  		/* Select blade/chiplet for GRU context */
> -		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
> -		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
> +		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
> +			req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
> +			(req.val1 >= 0 && !gru_base[req.val1])) {
>  			ret = -EINVAL;

I generally prefer how in the original code all the sub conditions
were aligned nicely but I will Ack your version as well.  Thanks.

regards,
dan carpenter

>  		} else {
>  			gts->ts_user_blade_id = req.val1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [patch] gru: fix a sanity test in gru_set_context_option()
  2013-05-19 18:30     ` Dan Carpenter
@ 2013-05-20 13:46       ` Dimitri Sivanich
  -1 siblings, 0 replies; 10+ messages in thread
From: Dimitri Sivanich @ 2013-05-20 13:46 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Robin Holt, linux-kernel, kernel-janitors

On Sun, May 19, 2013 at 09:30:41PM +0300, Dan Carpenter wrote:
> On Sun, May 19, 2013 at 09:44:42AM -0500, Dimitri Sivanich wrote:
> > 
> > Since we're here, maybe we should neaten this up a little?
> > 
> > Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> > ---
> >  drivers/misc/sgi-gru/grufault.c |    5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > Index: linux/drivers/misc/sgi-gru/grufault.c
> > =================================> > --- linux.orig/drivers/misc/sgi-gru/grufault.c
> > +++ linux/drivers/misc/sgi-gru/grufault.c
> > @@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
> >  	switch (req.op) {
> >  	case sco_blade_chiplet:
> >  		/* Select blade/chiplet for GRU context */
> > -		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
> > -		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
> > +		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
> > +			req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
> > +			(req.val1 >= 0 && !gru_base[req.val1])) {
> >  			ret = -EINVAL;
> 
> I generally prefer how in the original code all the sub conditions
> were aligned nicely but I will Ack your version as well.  Thanks.
> 

I guess I'd have to agree.  How about this?

Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
---
 drivers/misc/sgi-gru/grufault.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux/drivers/misc/sgi-gru/grufault.c
=================================--- linux.orig/drivers/misc/sgi-gru/grufault.c
+++ linux/drivers/misc/sgi-gru/grufault.c
@@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
 	switch (req.op) {
 	case sco_blade_chiplet:
 		/* Select blade/chiplet for GRU context */
-		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
-		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
+		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
+		    req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
+		    (req.val1 >= 0 && !gru_base[req.val1])) {
 			ret = -EINVAL;
 		} else {
 			gts->ts_user_blade_id = req.val1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [patch] gru: fix a sanity test in gru_set_context_option()
@ 2013-05-20 13:46       ` Dimitri Sivanich
  0 siblings, 0 replies; 10+ messages in thread
From: Dimitri Sivanich @ 2013-05-20 13:46 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Robin Holt, linux-kernel, kernel-janitors

On Sun, May 19, 2013 at 09:30:41PM +0300, Dan Carpenter wrote:
> On Sun, May 19, 2013 at 09:44:42AM -0500, Dimitri Sivanich wrote:
> > 
> > Since we're here, maybe we should neaten this up a little?
> > 
> > Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> > ---
> >  drivers/misc/sgi-gru/grufault.c |    5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > Index: linux/drivers/misc/sgi-gru/grufault.c
> > ===================================================================
> > --- linux.orig/drivers/misc/sgi-gru/grufault.c
> > +++ linux/drivers/misc/sgi-gru/grufault.c
> > @@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
> >  	switch (req.op) {
> >  	case sco_blade_chiplet:
> >  		/* Select blade/chiplet for GRU context */
> > -		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
> > -		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
> > +		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
> > +			req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
> > +			(req.val1 >= 0 && !gru_base[req.val1])) {
> >  			ret = -EINVAL;
> 
> I generally prefer how in the original code all the sub conditions
> were aligned nicely but I will Ack your version as well.  Thanks.
> 

I guess I'd have to agree.  How about this?

Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
---
 drivers/misc/sgi-gru/grufault.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux/drivers/misc/sgi-gru/grufault.c
===================================================================
--- linux.orig/drivers/misc/sgi-gru/grufault.c
+++ linux/drivers/misc/sgi-gru/grufault.c
@@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
 	switch (req.op) {
 	case sco_blade_chiplet:
 		/* Select blade/chiplet for GRU context */
-		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
-		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
+		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
+		    req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
+		    (req.val1 >= 0 && !gru_base[req.val1])) {
 			ret = -EINVAL;
 		} else {
 			gts->ts_user_blade_id = req.val1;

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [patch] gru: fix a sanity test in gru_set_context_option()
  2013-05-20 13:46       ` Dimitri Sivanich
@ 2013-05-20 18:06         ` Dan Carpenter
  -1 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2013-05-20 18:06 UTC (permalink / raw)
  To: Dimitri Sivanich; +Cc: Robin Holt, linux-kernel, kernel-janitors

On Mon, May 20, 2013 at 08:46:21AM -0500, Dimitri Sivanich wrote:
> On Sun, May 19, 2013 at 09:30:41PM +0300, Dan Carpenter wrote:
> > On Sun, May 19, 2013 at 09:44:42AM -0500, Dimitri Sivanich wrote:
> > > 
> > > Since we're here, maybe we should neaten this up a little?
> > > 
> > > Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> > > ---
> > >  drivers/misc/sgi-gru/grufault.c |    5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > Index: linux/drivers/misc/sgi-gru/grufault.c
> > > =================================> > > --- linux.orig/drivers/misc/sgi-gru/grufault.c
> > > +++ linux/drivers/misc/sgi-gru/grufault.c
> > > @@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
> > >  	switch (req.op) {
> > >  	case sco_blade_chiplet:
> > >  		/* Select blade/chiplet for GRU context */
> > > -		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
> > > -		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
> > > +		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
> > > +			req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
> > > +			(req.val1 >= 0 && !gru_base[req.val1])) {
> > >  			ret = -EINVAL;
> > 
> > I generally prefer how in the original code all the sub conditions
> > were aligned nicely but I will Ack your version as well.  Thanks.
> > 
> 
> I guess I'd have to agree.  How about this?

Looks nice.  Starting with zero is obviously better than the
original.

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [patch] gru: fix a sanity test in gru_set_context_option()
@ 2013-05-20 18:06         ` Dan Carpenter
  0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2013-05-20 18:06 UTC (permalink / raw)
  To: Dimitri Sivanich; +Cc: Robin Holt, linux-kernel, kernel-janitors

On Mon, May 20, 2013 at 08:46:21AM -0500, Dimitri Sivanich wrote:
> On Sun, May 19, 2013 at 09:30:41PM +0300, Dan Carpenter wrote:
> > On Sun, May 19, 2013 at 09:44:42AM -0500, Dimitri Sivanich wrote:
> > > 
> > > Since we're here, maybe we should neaten this up a little?
> > > 
> > > Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> > > ---
> > >  drivers/misc/sgi-gru/grufault.c |    5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > Index: linux/drivers/misc/sgi-gru/grufault.c
> > > ===================================================================
> > > --- linux.orig/drivers/misc/sgi-gru/grufault.c
> > > +++ linux/drivers/misc/sgi-gru/grufault.c
> > > @@ -876,8 +876,9 @@ int gru_set_context_option(unsigned long
> > >  	switch (req.op) {
> > >  	case sco_blade_chiplet:
> > >  		/* Select blade/chiplet for GRU context */
> > > -		if (req.val1 < -1 || req.val1 >= GRU_MAX_BLADES || !gru_base[req.val1] ||
> > > -		    req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB) {
> > > +		if (req.val0 < -1 || req.val0 >= GRU_CHIPLETS_PER_HUB ||
> > > +			req.val1 < -1 || req.val1 >= GRU_MAX_BLADES ||
> > > +			(req.val1 >= 0 && !gru_base[req.val1])) {
> > >  			ret = -EINVAL;
> > 
> > I generally prefer how in the original code all the sub conditions
> > were aligned nicely but I will Ack your version as well.  Thanks.
> > 
> 
> I guess I'd have to agree.  How about this?

Looks nice.  Starting with zero is obviously better than the
original.

Acked-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2013-05-20 18:06 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-19 12:59 [patch] gru: fix a sanity test in gru_set_context_option() Dan Carpenter
2013-05-19 12:59 ` Dan Carpenter
2013-05-19 14:44 ` Dimitri Sivanich
2013-05-19 14:44   ` Dimitri Sivanich
2013-05-19 18:30   ` Dan Carpenter
2013-05-19 18:30     ` Dan Carpenter
2013-05-20 13:46     ` Dimitri Sivanich
2013-05-20 13:46       ` Dimitri Sivanich
2013-05-20 18:06       ` Dan Carpenter
2013-05-20 18:06         ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.