From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Sun, 19 May 2013 18:49:05 +0200 Subject: [RFC 4/4] DRM: tda998x: add missing include In-Reply-To: <51988D88.10306@gmail.com> References: <20130516192510.GV18614@n2100.arm.linux.org.uk> <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com> <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> <20130518194644.2a02a4fc@armhf> <20130518205845.2dfe9fe5@armhf> <5197D6C1.3060702@gmail.com> <20130519080152.0b486b75@armhf> <51988D88.10306@gmail.com> Message-ID: <20130519184905.1f238710@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 19 May 2013 10:30:00 +0200 Sebastian Hesselbarth wrote: > > /* --- test (not cubox) ---- * > > &dcon { status = "okay"; }; > > > > &lcd1 { > > status = "okay"; > > clocks =<&core_clk 3>,<0>,<&lcdclk>,<0>; > > marvell,port-type =<1>; > > display-timings { > > mode { > > hactive =<1920>; > > vactive =<1080>; > > hfront-porch =<88>; > > hsync-len =<44>; > > hback-porch =<148>; > > vfront-porch =<4>; > > vsync-len =<5>; > > vback-porch =<36>; > > clock =<148500>; > > }; > > }; > > I would be surprised if, lcd1 will ever be capable of driving > 1080p60 on a *VGA port*! As you may see, this sequence is preceded by an open comment: "test". Now, as the port B of the display controller is only VGA (this is checked in my driver), as there is no VGA connector on the Cubox, as there is no VGA DAC code in my driver, and as I had to test the display controller, I: - defined the port B as VGA, - set the timings of the mode I use for my HDMI display. This does not mean the example must be used in the real word. It is just a working example for test purpose. > Seriously, start _reading_ what we say. I want all those > features I already told you for your driver, in mainline driver > too. All I told you was to prevent you from doing dirty little > Cubox specific hacks that I would have to remove for e.g. D2Plug. There is _NO_ Cubox specific stuff in my driver (I don't even use any cubox-setup as Russell) and it should work without any change (except the DT) in your D2plug. Remember, all my drm driver work is in http://moinejf.free.fr/cubox/ as a big kernel patch (I will add the I2C: mv64xxx which work fine - thanks Russell). > *But* if you ask me if we should take Russell's or your driver > as a basis, the answer is Russell's. Colon. OK. Do what you want. My driver works fine enough for my usage: software development. For video, my ISP gives us for free a Atom based multimedia player with a Blue-Ray reader, and I have a AMD64 double core on my family TV set for internet video (it will be a long time till there will be VP8 decoding with vMeta). The only interest I see in the Cubox is its low power consumption. Now, I will switch back to my favorite long-distance development... See you. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [RFC 4/4] DRM: tda998x: add missing include Date: Sun, 19 May 2013 18:49:05 +0200 Message-ID: <20130519184905.1f238710@armhf> References: <20130516192510.GV18614@n2100.arm.linux.org.uk> <1368897139-25485-1-git-send-email-sebastian.hesselbarth@gmail.com> <1368897139-25485-5-git-send-email-sebastian.hesselbarth@gmail.com> <20130518194644.2a02a4fc@armhf> <20130518205845.2dfe9fe5@armhf> <5197D6C1.3060702@gmail.com> <20130519080152.0b486b75@armhf> <51988D88.10306@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <51988D88.10306@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sebastian Hesselbarth Cc: Rob Clark , Russell King , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Jason Cooper List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAxOSBNYXkgMjAxMyAxMDozMDowMCArMDIwMApTZWJhc3RpYW4gSGVzc2VsYmFydGgg PHNlYmFzdGlhbi5oZXNzZWxiYXJ0aEBnbWFpbC5jb20+IHdyb3RlOgo+ID4gLyogLS0tIHRlc3Qg KG5vdCBjdWJveCkgLS0tLSAqCj4gPiAmZGNvbiB7IHN0YXR1cyA9ICJva2F5IjsgfTsKPiA+IAo+ ID4gJmxjZDEgewo+ID4gCXN0YXR1cyA9ICJva2F5IjsKPiA+IAljbG9ja3MgPTwmY29yZV9jbGsg Mz4sPDA+LDwmbGNkY2xrPiw8MD47Cj4gPiAJbWFydmVsbCxwb3J0LXR5cGUgPTwxPjsKPiA+IAlk aXNwbGF5LXRpbWluZ3Mgewo+ID4gCQltb2RlIHsKPiA+IAkJCWhhY3RpdmUgPTwxOTIwPjsKPiA+ IAkJCXZhY3RpdmUgPTwxMDgwPjsKPiA+IAkJCWhmcm9udC1wb3JjaCA9PDg4PjsKPiA+IAkJCWhz eW5jLWxlbiA9PDQ0PjsKPiA+IAkJCWhiYWNrLXBvcmNoID08MTQ4PjsKPiA+IAkJCXZmcm9udC1w b3JjaCA9PDQ+Owo+ID4gCQkJdnN5bmMtbGVuID08NT47Cj4gPiAJCQl2YmFjay1wb3JjaCA9PDM2 PjsKPiA+IAkJCWNsb2NrID08MTQ4NTAwPjsKPiA+IAkJfTsKPiA+IAl9OyAgCj4gCj4gSSB3b3Vs ZCBiZSBzdXJwcmlzZWQgaWYsIGxjZDEgd2lsbCBldmVyIGJlIGNhcGFibGUgb2YgZHJpdmluZwo+ IDEwODBwNjAgb24gYSAqVkdBIHBvcnQqIQoKQXMgeW91IG1heSBzZWUsIHRoaXMgc2VxdWVuY2Ug aXMgcHJlY2VkZWQgYnkgYW4gb3BlbiBjb21tZW50OiAidGVzdCIuCgpOb3csIGFzIHRoZSBwb3J0 IEIgb2YgdGhlIGRpc3BsYXkgY29udHJvbGxlciBpcyBvbmx5IFZHQSAodGhpcyBpcwpjaGVja2Vk IGluIG15IGRyaXZlciksIGFzIHRoZXJlIGlzIG5vIFZHQSBjb25uZWN0b3Igb24gdGhlIEN1Ym94 LCBhcwp0aGVyZSBpcyBubyBWR0EgREFDIGNvZGUgaW4gbXkgZHJpdmVyLCBhbmQgYXMgSSBoYWQg dG8gdGVzdCB0aGUgZGlzcGxheQpjb250cm9sbGVyLCBJOgoKLSBkZWZpbmVkIHRoZSBwb3J0IEIg YXMgVkdBLAoKLSBzZXQgdGhlIHRpbWluZ3Mgb2YgdGhlIG1vZGUgSSB1c2UgZm9yIG15IEhETUkg ZGlzcGxheS4KClRoaXMgZG9lcyBub3QgbWVhbiB0aGUgZXhhbXBsZSBtdXN0IGJlIHVzZWQgaW4g dGhlIHJlYWwgd29yZC4gSXQgaXMKanVzdCBhIHdvcmtpbmcgZXhhbXBsZSBmb3IgdGVzdCBwdXJw b3NlLgoKPiBTZXJpb3VzbHksIHN0YXJ0IF9yZWFkaW5nXyB3aGF0IHdlIHNheS4gSSB3YW50IGFs bCB0aG9zZQo+IGZlYXR1cmVzIEkgYWxyZWFkeSB0b2xkIHlvdSBmb3IgeW91ciBkcml2ZXIsIGlu IG1haW5saW5lIGRyaXZlcgo+IHRvby4gQWxsIEkgdG9sZCB5b3Ugd2FzIHRvIHByZXZlbnQgeW91 IGZyb20gZG9pbmcgZGlydHkgbGl0dGxlCj4gQ3Vib3ggc3BlY2lmaWMgaGFja3MgdGhhdCBJIHdv dWxkIGhhdmUgdG8gcmVtb3ZlIGZvciBlLmcuIEQyUGx1Zy4KClRoZXJlIGlzIF9OT18gQ3Vib3gg c3BlY2lmaWMgc3R1ZmYgaW4gbXkgZHJpdmVyIChJIGRvbid0IGV2ZW4gdXNlIGFueQpjdWJveC1z ZXR1cCBhcyBSdXNzZWxsKSBhbmQgaXQgc2hvdWxkIHdvcmsgd2l0aG91dCBhbnkgY2hhbmdlIChl eGNlcHQKdGhlIERUKSBpbiB5b3VyIEQycGx1Zy4gUmVtZW1iZXIsIGFsbCBteSBkcm0gZHJpdmVy IHdvcmsgaXMgaW4KaHR0cDovL21vaW5lamYuZnJlZS5mci9jdWJveC8gYXMgYSBiaWcga2VybmVs IHBhdGNoIChJIHdpbGwgYWRkIHRoZQpJMkM6IG12NjR4eHggd2hpY2ggd29yayBmaW5lIC0gdGhh bmtzIFJ1c3NlbGwpLgoKPiAqQnV0KiBpZiB5b3UgYXNrIG1lIGlmIHdlIHNob3VsZCB0YWtlIFJ1 c3NlbGwncyBvciB5b3VyIGRyaXZlcgo+IGFzIGEgYmFzaXMsIHRoZSBhbnN3ZXIgaXMgUnVzc2Vs bCdzLiBDb2xvbi4KCk9LLiBEbyB3aGF0IHlvdSB3YW50LiBNeSBkcml2ZXIgd29ya3MgZmluZSBl bm91Z2ggZm9yIG15IHVzYWdlOgpzb2Z0d2FyZSBkZXZlbG9wbWVudC4gRm9yIHZpZGVvLCBteSBJ U1AgZ2l2ZXMgdXMgZm9yIGZyZWUgYSBBdG9tIGJhc2VkCm11bHRpbWVkaWEgcGxheWVyIHdpdGgg YSBCbHVlLVJheSByZWFkZXIsIGFuZCBJIGhhdmUgYSBBTUQ2NCBkb3VibGUKY29yZSBvbiBteSBm YW1pbHkgVFYgc2V0IGZvciBpbnRlcm5ldCB2aWRlbyAoaXQgd2lsbCBiZSBhIGxvbmcgdGltZQp0 aWxsIHRoZXJlIHdpbGwgYmUgVlA4IGRlY29kaW5nIHdpdGggdk1ldGEpLiBUaGUgb25seSBpbnRl cmVzdCBJIHNlZQppbiB0aGUgQ3Vib3ggaXMgaXRzIGxvdyBwb3dlciBjb25zdW1wdGlvbi4KCk5v dywgSSB3aWxsIHN3aXRjaCBiYWNrIHRvIG15IGZhdm9yaXRlIGxvbmctZGlzdGFuY2UgZGV2ZWxv cG1lbnQuLi4KClNlZSB5b3UuCgotLSAKS2VuIGFyIGMnaGVudGHDsQl8CSAgICAgICoqIEJyZWl6 aCBoYSBMaW51eCBhdGF2ISAqKgpKZWYJCXwJCWh0dHA6Ly9tb2luZWpmLmZyZWUuZnIvCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==