From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 1/2 V4] virtio-spec: dynamic network offloads configuration Date: Mon, 20 May 2013 16:48:40 +0300 Message-ID: <20130520134840.GB12441@redhat.com> References: <1365062118-907-1-git-send-email-dmitry@daynix.com> <1365062118-907-3-git-send-email-dmitry@daynix.com> <519A2897.9020207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <519A2897.9020207@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Paolo Bonzini Cc: qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Yan Vugenfirer , Ronen Hod , Dmitry Fleytman List-Id: virtualization@lists.linuxfoundation.org On Mon, May 20, 2013 at 03:43:51PM +0200, Paolo Bonzini wrote: > Il 04/04/2013 09:55, Dmitry Fleytman ha scritto: > > From: Dmitry Fleytman > > > > Virtio-net driver currently negotiates network offloads > > on startup via features mechanism and have no ability to > > disable and re-enable offloads later. > > This patch introduced a new control command that allows > > to configure device network offloads state dynamically. > > The patch also introduces a new feature flag > > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > > > Signed-off-by: Dmitry Fleytman > > --- > > virtio-spec.lyx | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 143 insertions(+) > > > > diff --git a/virtio-spec.lyx b/virtio-spec.lyx > > index 3d2f485..e9dbac4 100644 > > --- a/virtio-spec.lyx > > +++ b/virtio-spec.lyx > > @@ -60,6 +60,7 @@ > > \author -1930653948 "Amos Kong" > > \author -608949062 "Rusty Russell,,," > > \author -385801441 "Cornelia Huck" cornelia.huck@de.ibm.com > > +\author 460276516 "Dmitry Fleytman" dfleytma@redhat.com > > \author 1112500848 "Rusty Russell" rusty@rustcorp.com.au > > \author 1531152142 "Paolo Bonzini,,," > > \author 1717892615 "Alexey Zaytsev,,," > > @@ -4261,6 +4262,20 @@ VIRTIO_NET_F_GUEST_CSUM > > \end_inset > > > > (1) Guest handles packets with partial checksum > > +\change_inserted 460276516 1363712169 > > + > > +\end_layout > > + > > +\begin_layout Description > > + > > +\change_inserted 460276516 1363712334 > > +VIRTIO_NET_F_CTRL_GUEST_OFFLOADS > > +\begin_inset space ~ > > +\end_inset > > + > > +(2) Control channel offloads reconfiguration support. > > +\change_unchanged > > Rusty, > > you might have missed this patch because your address was misspelled. It's commit 721861222802d0ebc48564d727a3684f7b21cadd in https://github.com/rustyrussell/virtio-spec > Is there a story behind skipping virtio-net feature bits 2..4? > > Paolo Bits 3-4 now :) I'm curious too. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeQRz-0001ch-LJ for qemu-devel@nongnu.org; Mon, 20 May 2013 09:48:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeQRt-0006kG-8L for qemu-devel@nongnu.org; Mon, 20 May 2013 09:48:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeQRs-0006jV-W1 for qemu-devel@nongnu.org; Mon, 20 May 2013 09:48:25 -0400 Date: Mon, 20 May 2013 16:48:40 +0300 From: "Michael S. Tsirkin" Message-ID: <20130520134840.GB12441@redhat.com> References: <1365062118-907-1-git-send-email-dmitry@daynix.com> <1365062118-907-3-git-send-email-dmitry@daynix.com> <519A2897.9020207@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519A2897.9020207@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2 V4] virtio-spec: dynamic network offloads configuration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Rusty Russell , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Yan Vugenfirer , Ronen Hod , Dmitry Fleytman , Dmitry Fleytman On Mon, May 20, 2013 at 03:43:51PM +0200, Paolo Bonzini wrote: > Il 04/04/2013 09:55, Dmitry Fleytman ha scritto: > > From: Dmitry Fleytman > > > > Virtio-net driver currently negotiates network offloads > > on startup via features mechanism and have no ability to > > disable and re-enable offloads later. > > This patch introduced a new control command that allows > > to configure device network offloads state dynamically. > > The patch also introduces a new feature flag > > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > > > Signed-off-by: Dmitry Fleytman > > --- > > virtio-spec.lyx | 143 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 143 insertions(+) > > > > diff --git a/virtio-spec.lyx b/virtio-spec.lyx > > index 3d2f485..e9dbac4 100644 > > --- a/virtio-spec.lyx > > +++ b/virtio-spec.lyx > > @@ -60,6 +60,7 @@ > > \author -1930653948 "Amos Kong" > > \author -608949062 "Rusty Russell,,," > > \author -385801441 "Cornelia Huck" cornelia.huck@de.ibm.com > > +\author 460276516 "Dmitry Fleytman" dfleytma@redhat.com > > \author 1112500848 "Rusty Russell" rusty@rustcorp.com.au > > \author 1531152142 "Paolo Bonzini,,," > > \author 1717892615 "Alexey Zaytsev,,," > > @@ -4261,6 +4262,20 @@ VIRTIO_NET_F_GUEST_CSUM > > \end_inset > > > > (1) Guest handles packets with partial checksum > > +\change_inserted 460276516 1363712169 > > + > > +\end_layout > > + > > +\begin_layout Description > > + > > +\change_inserted 460276516 1363712334 > > +VIRTIO_NET_F_CTRL_GUEST_OFFLOADS > > +\begin_inset space ~ > > +\end_inset > > + > > +(2) Control channel offloads reconfiguration support. > > +\change_unchanged > > Rusty, > > you might have missed this patch because your address was misspelled. It's commit 721861222802d0ebc48564d727a3684f7b21cadd in https://github.com/rustyrussell/virtio-spec > Is there a story behind skipping virtio-net feature bits 2..4? > > Paolo Bits 3-4 now :) I'm curious too. -- MST