[Bug 58521] New: Radeon ATOM BIOS have wrong value in controller->ucType for RV635

[Bug 58521] New: Radeon ATOM BIOS have wrong value in controller->ucType for RV635

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521

           Summary: Radeon ATOM BIOS have wrong value in
                    controller->ucType for RV635
           Product: Drivers
           Version: 2.5
    Kernel Version: 3.5.0
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
        AssignedTo: drivers_video-dri@kernel-bugs.osdl.org
        ReportedBy: guram.savinov@gmail.com
        Regression: No


I have Asus M50Sa laptop with ATI Radeon Mobility HD3650(RV635 chip) graphics.
RV635 chip have internal thermal sensor, but for my graphics it's no hwmon
entry in /sys/class/hwmon.

I found that in radeon_atombios.c it's checking for thermal sensor from ATOM
BIOS structure:

##################################
static void radeon_atombios_add_pplib_thermal_controller(struct radeon_device
*rdev,
                                                        
ATOM_PPLIB_THERMALCONTROLLER *controller)
{
        struct radeon_i2c_bus_rec i2c_bus;

        /* add the i2c bus for thermal/fan chip */
        if (controller->ucType > 0) {
                if (controller->ucType == ATOM_PP_THERMALCONTROLLER_RV6xx) {
                        DRM_INFO("Internal thermal controller %s fan
control\n",
                                 (controller->ucFanParameters &
                                  ATOM_PP_FANPARAMETERS_NOFAN) ? "without" :
"with");
                        rdev->pm.int_thermal_type = THERMAL_TYPE_RV6XX;
                } else if (controller->ucType ==
ATOM_PP_THERMALCONTROLLER_RV770) {

...
###################################

But for my graphics controller->ucType have 0, that mean 
ATOM_PP_THERMALCONTROLLER_NONE.
I try to set THERMAL_TYPE_RV6XX to controller->ucType, hwmon was added and I
have thermal sensor for my RV635 chip, all works great.

May be it's Asus M50Sa ATOM BIOS bug, but why you check thermal sensor for
RV635?
Is it possible to have RV635 chip without internal thermal sensor?

It'll be great to not check thermal sensor type for RV635 chip, because AMD say
that it shipped with internal thermal sensor.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521


Guram Savinov <guram.savinov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guram.savinov@gmail.com
           Platform|All                         |x86-64




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521


Guram Savinov <guram.savinov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Radeon ATOM BIOS have wrong |Radeon ATOM BIOS have wrong
                   |value in controller->ucType |value in controller->ucType
                   |for RV635                   |for RV635 chip




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521


Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com




--- Comment #1 from Alex Deucher <alexdeucher@gmail.com>  2013-05-20 13:02:30 ---
A lot of laptop OEMs don't use the internal thermal sensor.  In most cases they
use a platform specific thermal sensor since they often cover multiple
components with the same thermal zone.  It's usually exposed via a platform
specific acpi thermal zone or acpi temperature sensor.  It's not a bios bug;
very few r6xx/r7xx laptops expose the internal thermal sensor.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521





--- Comment #2 from Guram Savinov <guram.savinov@gmail.com>  2013-05-20 13:11:13 ---
In this case it will be better to setup internal thermal sensor without
checking AtomBIOS thermal sensor info value, isn't it?

It's no a lot chanses to have acpi sensors support in linux kernel.
I think if we know that chip have internal sensor, we should setup it.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521





--- Comment #3 from Alex Deucher <alexdeucher@gmail.com>  2013-05-20 13:22:00 ---
It might produce garbage results depending on the thermal solution from the
OEM.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521





--- Comment #4 from Guram Savinov <guram.savinov@gmail.com>  2013-05-20 13:32:03 ---
Is it possible to implement force enabling internal sensor configuration by
conf file?
Because OEM's disable thermal sensor info in AtomBIOS we haven't sensor for
GPU.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521





--- Comment #5 from Guram Savinov <guram.savinov@gmail.com>  2013-05-20 13:38:48 ---
>>It might produce garbage results depending on the thermal solution from the
OEM.

OEM? I talk about ATI on-chip thermal sensor, it's not OEM, right?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521





--- Comment #6 from Alex Deucher <alexdeucher@gmail.com>  2013-05-20 13:47:01 ---
The OEM designs the thermal solution for the laptop.  If they choose not to use
the internal thermal sensor, there is no guarantee that it's calibrated
correctly for their specific system.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521





--- Comment #7 from Guram Savinov <guram.savinov@gmail.com>  2013-05-20 13:52:21 ---
Ok, but how about comment#4, is it possible?

By default sensor will be initialized as it implemented now, but it will be
possible to override OEM configuration that disable internal sensor.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521





--- Comment #8 from Alex Deucher <alexdeucher@gmail.com>  2013-05-20 13:59:06 ---
I'd prefer not to.  These sort of options tend to be abused.  Users and
possibly some distros will start forcing the option on, and then we'll get
swamped with bug reports about garbage temperatures where the reporter will
fail to note that they forced the option on.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521


Rafał Miłecki <zajec5@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zajec5@gmail.com




--- Comment #9 from Rafał Miłecki <zajec5@gmail.com>  2013-05-20 14:05:32 ---
(In reply to comment #8)
> I'd prefer not to.  These sort of options tend to be abused.  Users and
> possibly some distros will start forcing the option on, and then we'll get
> swamped with bug reports about garbage temperatures where the reporter will
> fail to note that they forced the option on.

Sounds sane.

@Guram: what about ACPI? Did you investigate why Linux doesn't export thermal
info from it?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 58521] Radeon ATOM BIOS have wrong value in controller->ucType for RV635 chip

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=58521





--- Comment #10 from Guram Savinov <guram.savinov@gmail.com>  2013-05-20 14:48:17 ---
>>@Guram: what about ACPI? Did you investigate why Linux doesn't export thermal
info from it?

Maybe Asus M50Sa laptop have no hardware ACPI thermal sensors.
If it exist I think Asus include any monitor software tool with laptop CD's.

99% that ATI internal sensor only one way to get GPU themperature.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.