All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Jon Arne Jørgensen" <jonarne@jonarne.no>
Cc: Andy Walls <awalls@md.metrocast.net>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	Timo Teras <timo.teras@iki.fi>,
	linux-media@vger.kernel.org
Subject: Re: saa7115/gm7113c - device specific initialization
Date: Mon, 20 May 2013 18:00:29 -0300	[thread overview]
Message-ID: <20130520180029.7e487432@redhat.com> (raw)
In-Reply-To: <20130520162044.GB14615@dell.arpanet.local>

Em Mon, 20 May 2013 18:20:44 +0200
Jon Arne Jørgensen <jonarne@jonarne.no> escreveu:

> On Mon, May 20, 2013 at 06:33:20AM -0400, Andy Walls wrote:
> > "Jon Arne Jørgensen" <jonarne@jonarne.no> wrote:
> > 
> > >Hi,
> > >I've recently discovered that the smi2021 device have some pretty
> > >specific
> > >needs for the setup of the gm7113c chip.
> > >
> > >Both the smi2021 driver and the stk1160 driver needs registers
> > >0x14 -> 0x17 to be zeroed, this is what forced me to add the gm7113c
> > >chip to the saa7115 driver in the first place.
> > >
> > >Then Timo reported that the Terratec Grabby hwrev2 needs some of the
> > >initial register settings to be changed for the device to work.
> > >He posted a small list of required changes.
> > >One of these changes is a change to register 0x12 which sets
> > >up what to output on the RTS0 pin on the chip.
> > >
> > >Then I discovered that the smi2021 needs the V-Flag in the SAV/EAV
> > >to be generated by VREF - whatever that means :).
> > >That is, I need bit 7 to be clear and bit 6 to be set in register 0x10.
> > >To have the device behave correctly.
> > >
> > >Both the change for the smi2021 driver and the changes for the Terratec
> > >device are pretty hardware specific.
> > >They should probably not be part of the generic gm7113c setup.
> > >
> > >I would also guess that if other devices with the gm7113c chip should
> > >surface, these devices might also have different needs for the setup of
> > >the chip.
> > >
> > >I'm not sure what would be the correct way to handle these
> > >differences.
> > >The only sollution I'we tried is to bypass the saa7115
> > >driver, and push the needed changes directly over usb to the device,
> > >after the initial setup is sent by the saa7115 driver.
> > >This is a major hack, and the changes should probably go through
> > >the saa7115 driver.
> > >
> > >Should the saa7115 driver be extended with an interface to change
> > >random
> > >register settings, or does the i2c subsystem already have a way to
> > >handle this?
> > >
> > >Any idea about what might could be a better sollution?
> > >
> > >Best regards
> > >Jon Arne Jørgensen
> > >
> > >--
> > >To unsubscribe from this list: send the line "unsubscribe linux-media"
> > >in
> > >the body of a message to majordomo@vger.kernel.org
> > >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > For v4l2_subdev's there is a way to pass in platform/bridge device specific data so initialization can be different than the default, based on the needs of the bridge driver.
> 
> Ok, can you give any pointers to any documentation/source files I can
> look at for this?

Look, for example, at drivers/media/i2c/mt9v011.c. At mt9v011_probe, it
checks if c->dev.platform_data exists. If so, it changes the xtal frequency
to the one specified by the driver.

-- 

Cheers,
Mauro

  parent reply	other threads:[~2013-05-20 21:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 10:24 saa7115/gm7113c - device specific initialization Jon Arne Jørgensen
2013-05-20 10:33 ` Andy Walls
2013-05-20 16:20   ` Jon Arne Jørgensen
2013-05-20 16:42     ` Andy Walls
2013-05-26  7:20       ` Jon Arne Jørgensen
2013-05-20 21:00     ` Mauro Carvalho Chehab [this message]
2013-05-26  7:21       ` Jon Arne Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130520180029.7e487432@redhat.com \
    --to=mchehab@redhat.com \
    --cc=awalls@md.metrocast.net \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=jonarne@jonarne.no \
    --cc=linux-media@vger.kernel.org \
    --cc=timo.teras@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.