From: Dave Chinner <david@fromorbit.com>
To: Itaru Kitayama <itaru.kitayama@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests comma separated group names
Date: Tue, 21 May 2013 10:45:53 +1000 [thread overview]
Message-ID: <20130521004553.GL24543@dastard> (raw)
In-Reply-To: <CANW9uytQDPaBr_VAGMuwSqhStCfyMCGmV_A3ccNzOExi-KeZfQ@mail.gmail.com>
On Mon, May 20, 2013 at 08:42:35PM +0900, Itaru Kitayama wrote:
> Yes, we can do that, but I just thought as you originally proposed last year
>
> -g rw,attr reads better.
Agreed, it does read better and is easily to type.
That's what you need to put in the commit message - why it is better
than what we currently have, and whether it is badwards compatible
or not (doesn't break any existing scripts). i.e. the commit
message is for telling people -why- the change should be made as we
can look at the code to determine -what- the change is. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-21 0:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 8:29 [PATCH] xfstests comma separated group names Itaru Kitayama
2013-05-20 11:30 ` Dave Chinner
2013-05-20 11:42 ` Itaru Kitayama
2013-05-21 0:45 ` Dave Chinner [this message]
2013-05-21 3:45 ` Itaru Kitayama
2013-05-21 5:21 ` Dave Chinner
2013-05-22 14:12 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521004553.GL24543@dastard \
--to=david@fromorbit.com \
--cc=itaru.kitayama@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.