Re: [Qemu-devel] (Another) 1.4.1 -> 1.5.0 migration failure

[mdroth <mdroth@linux.vnet.ibm.com>]

On Tue, May 21, 2013 at 11:55:56AM -0500, mdroth wrote:
> On Tue, May 21, 2013 at 12:33:38PM +0100, Nicholas Thomas wrote:
> > Hi all,
> > 
> > Migrating from:
> > 
> > /opt/qemu-1.4.1/bin/qemu-system-x86_64 -M pc -watchdog i6300esb
> > -watchdog-action reset [...] 
> > 
> > to:
> > 
> > /opt/qemu-1.5.0/bin/qemu-system-x86_64 -M pc-i440fx-1.4 -watchdog
> > i6300esb -watchdog-action reset [...] 
> > 
> > I get: 
> > 
> > qemu: warning: error while loading state for instance 0x0 of device
> > '0000:00:06.0/i6300esb_wdt'
> > load of migration failed
> > 
> > Perhaps a similar issue to the network device one? I'm afraid I'm not
> > sure how to debug these...
> 
> Doesn't look like it, here's a dump of the SaveStateEntry's (i just
> added some debug statements in vmstate_register_with_alias_id):
> 
> verison: 1.4.1, se->idstr: timer, se->instance_id: 0
> verison: 1.4.1, se->idstr: cpu_common, se->instance_id: 0
> verison: 1.4.1, se->idstr: kvm-tpr-opt, se->instance_id: 0
> verison: 1.4.1, se->idstr: apic, se->instance_id: 0
> verison: 1.4.1, se->idstr: kvmclock, se->instance_id: 0
> verison: 1.4.1, se->idstr: fw_cfg, se->instance_id: 0
> verison: 1.4.1, se->idstr: PCIBUS, se->instance_id: 0
> verison: 1.4.1, se->idstr: 0000:00:00.0/I440FX, se->instance_id: 0
> verison: 1.4.1, se->idstr: 0000:00:01.0/PIIX3, se->instance_id: 0
> verison: 1.4.1, se->idstr: i8259, se->instance_id: 0
> verison: 1.4.1, se->idstr: i8259, se->instance_id: 1
> verison: 1.4.1, se->idstr: ioapic, se->instance_id: 0
> verison: 1.4.1, se->idstr: 0000:00:02.0/vga, se->instance_id: 0
> verison: 1.4.1, se->idstr: hpet, se->instance_id: 0
> verison: 1.4.1, se->idstr: mc146818rtc, se->instance_id: 0
> verison: 1.4.1, se->idstr: i8254, se->instance_id: 0
> verison: 1.4.1, se->idstr: serial, se->instance_id: 0
> verison: 1.4.1, se->idstr: ps2kbd, se->instance_id: 0
> verison: 1.4.1, se->idstr: ps2mouse, se->instance_id: 0
> verison: 1.4.1, se->idstr: pckbd, se->instance_id: 0
> verison: 1.4.1, se->idstr: vmmouse, se->instance_id: 0
> verison: 1.4.1, se->idstr: port92, se->instance_id: 0
> verison: 1.4.1, se->idstr: dma, se->instance_id: 0
> verison: 1.4.1, se->idstr: dma, se->instance_id: 1
> verison: 1.4.1, se->idstr: fdc, se->instance_id: 0
> verison: 1.4.1, se->idstr: 0000:00:01.1/ide, se->instance_id: 0
> verison: 1.4.1, se->idstr: i2c_bus, se->instance_id: 0
> verison: 1.4.1, se->idstr: 0000:00:01.3/piix4_pm, se->instance_id: 0
> verison: 1.4.1, se->idstr: 0000:00:06.0/i6300esb_wdt, se->instance_id: 0
> 
> version: 1.5.0, se->idstr: timer, se->instance_id: 0
> version: 1.5.0, se->idstr: cpu_common, se->instance_id: 0
> version: 1.5.0, se->idstr: cpu, se->instance_id: 0
> version: 1.5.0, se->idstr: kvm-tpr-opt, se->instance_id: 0
> version: 1.5.0, se->idstr: apic, se->instance_id: 0
> version: 1.5.0, se->idstr: kvmclock, se->instance_id: 0
> version: 1.5.0, se->idstr: fw_cfg, se->instance_id: 0
> version: 1.5.0, se->idstr: PCIBUS, se->instance_id: 0
> version: 1.5.0, se->idstr: 0000:00:00.0/I440FX, se->instance_id: 0
> version: 1.5.0, se->idstr: 0000:00:01.0/PIIX3, se->instance_id: 0
> version: 1.5.0, se->idstr: i8259, se->instance_id: 0
> version: 1.5.0, se->idstr: i8259, se->instance_id: 1
> version: 1.5.0, se->idstr: ioapic, se->instance_id: 0
> version: 1.5.0, se->idstr: 0000:00:02.0/vga, se->instance_id: 0
> version: 1.5.0, se->idstr: hpet, se->instance_id: 0
> version: 1.5.0, se->idstr: mc146818rtc, se->instance_id: 0
> version: 1.5.0, se->idstr: i8254, se->instance_id: 0
> version: 1.5.0, se->idstr: serial, se->instance_id: 0
> version: 1.5.0, se->idstr: ps2kbd, se->instance_id: 0
> version: 1.5.0, se->idstr: ps2mouse, se->instance_id: 0
> version: 1.5.0, se->idstr: pckbd, se->instance_id: 0
> version: 1.5.0, se->idstr: vmmouse, se->instance_id: 0
> version: 1.5.0, se->idstr: port92, se->instance_id: 0
> version: 1.5.0, se->idstr: dma, se->instance_id: 0
> version: 1.5.0, se->idstr: dma, se->instance_id: 1
> version: 1.5.0, se->idstr: fdc, se->instance_id: 0
> version: 1.5.0, se->idstr: 0000:00:01.1/ide, se->instance_id: 0
> version: 1.5.0, se->idstr: i2c_bus, se->instance_id: 0
> version: 1.5.0, se->idstr: 0000:00:01.3/piix4_pm, se->instance_id: 0
> version: 1.5.0, se->idstr: 0000:00:06.0/i6300esb_wdt, se->instance_id: 0
> 
> Seems like the actual load is failing, but the VMSD hasn't changed so
> i'm not sure what's going on.
> 

Ehhh...

static const VMStateDescription vmstate_i6300esb = {
    .name = "i6300esb_wdt",
    .version_id = sizeof(I6300State),
    .minimum_version_id = sizeof(I6300State),
    .minimum_version_id_old = sizeof(I6300State),
    .fields      = (VMStateField []) {
        VMSTATE_PCI_DEVICE(dev, I6300State),
        VMSTATE_INT32(reboot_enabled, I6300State),
        VMSTATE_INT32(clock_scale, I6300State),
        VMSTATE_INT32(int_type, I6300State),
        VMSTATE_INT32(free_run, I6300State),
        VMSTATE_INT32(locked, I6300State),
        VMSTATE_INT32(enabled, I6300State),
        VMSTATE_TIMER(timer, I6300State),
        VMSTATE_UINT32(timer1_preload, I6300State),
        VMSTATE_UINT32(timer2_preload, I6300State),
        VMSTATE_INT32(stage, I6300State),
        VMSTATE_INT32(unlock_state, I6300State),
        VMSTATE_INT32(previous_reboot_flag, I6300State),
        VMSTATE_END_OF_LIST()
    }
};

apparently minimum version ID is set the size of the device struct?

Almost certain that's the problem.

> > 
> > /Nick
> > 
> > 
> >