All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] mxs-bootlets: add support for custom patches
Date: Wed, 22 May 2013 08:58:04 +0200	[thread overview]
Message-ID: <20130522085804.5dbbbf4b@skate> (raw)
In-Reply-To: <519C60D6.5040207@mind.be>

Dear Arnout Vandecappelle,

On Wed, 22 May 2013 08:08:22 +0200, Arnout Vandecappelle wrote:

> > +config BR2_TARGET_MXS_BOOTLETS_CUSTOM_PATCH_DIR
> > +	string "custom patch dir"
> > +	help
> > +	  If your board requires custom patches, add the path to the
> > +	  directory containing the patches here. The patches must be
> > +	  named mxs-bootlets-<something>.patch.
> > +
> > +	  Most users may leave this empty
> > +
> 
>   Now that we have BR2_GLOBAL_PATCH_DIR, I would prefer to avoid adding 
> config options like this... Admittedly, for bootloaders it is more likely 
> that custom patches are needed than for any other package. But even so, 
> the global patch dir is sufficient, it is quite useable, and it reduces 
> complexity in the buildroot core.

This means that a defconfig would have to define a value for
BR2_GLOBAL_PATCH_DIR, in this particular case. Is this something we
really want?

Also, what about the existing *_CUSTOM_PATCH_DIR config options we have
for Linux, U-Boot, Barebox and a bunch of other boot/kernel packages?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-05-22  6:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-18 19:25 [Buildroot] [PATCH 1/2] mxs-bootlets: add support for custom patches Gustavo Zacarias
2013-05-18 19:25 ` [Buildroot] [PATCH 2/2] configs: add sample for olimex mx233 olinuxino Gustavo Zacarias
2013-05-22  6:08 ` [Buildroot] [PATCH 1/2] mxs-bootlets: add support for custom patches Arnout Vandecappelle
2013-05-22  6:58   ` Thomas Petazzoni [this message]
2013-05-22  7:01     ` Arnout Vandecappelle
2013-05-27 16:42       ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130522085804.5dbbbf4b@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.