From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: set active format aspect ratio same as picture aspect ratio Date: Wed, 22 May 2013 13:10:00 +0300 Message-ID: <20130522101000.GB28346@intel.com> References: <1369212495-29566-1-git-send-email-xiong.y.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E192E5BFE for ; Wed, 22 May 2013 03:10:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1369212495-29566-1-git-send-email-xiong.y.zhang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Xiong Zhang Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, May 22, 2013 at 04:48:15PM +0800, Xiong Zhang wrote: > HDMI Compliance Testing fail on i915 driver, the error log show: > M1-M0=3D0b00(NO Data) of AVI InfoFrame Packet should correspond to the > aspect ratio of the viewed image.Skip because AVI R3-R0 is no 1000 > (Same as picture aspect ratio) > = > the default value of active format aspect ratio is 0 which is invalid > accroding to CEA-861-D spec in page 79, So change the default value to > 0x08. If you look at Annex H, 0000 should actually be allowed. But since it should be interpreted the same as 1000, I guess we might as well make this change. Also, please change intel_sdvo.c too. > = > Signed-off-by: Xiong Zhang > --- > drivers/gpu/drm/i915/intel_drv.h | 1 + > drivers/gpu/drm/i915/intel_hdmi.c | 5 +++++ > 2 files changed, 6 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/inte= l_drv.h > index 75a7f22..91b345e 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -370,6 +370,7 @@ struct cxsr_latency { > #define DIP_TYPE_AVI 0x82 > #define DIP_VERSION_AVI 0x2 > #define DIP_LEN_AVI 13 > +#define DIP_AVI_FORMAT_ASPECT_RATIO_SAME 0x8 > #define DIP_AVI_PR_1 0 > #define DIP_AVI_PR_2 1 > #define DIP_AVI_RGB_QUANT_RANGE_DEFAULT (0 << 2) > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/int= el_hdmi.c > index 18f8ce0..599c013 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -340,6 +340,11 @@ static void intel_hdmi_set_avi_infoframe(struct drm_= encoder *encoder, > .len =3D DIP_LEN_AVI, > }; > = > + /*since the default picture aspect ratio is no data > + *set the default active format aspect ratio is the > + *same as picture aspect ratio*/ > + avi_if.body.avi.C_M_R =3D DIP_AVI_FORMAT_ASPECT_RATIO_SAME; > + > if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK) > avi_if.body.avi.YQ_CN_PR |=3D DIP_AVI_PR_2; > = > -- = > 1.7.9.5 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC