From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/6] drm/i915: Always enable the cursor
 right after the primary plane
Date: Wed, 22 May 2013 14:15:28 +0300
Message-ID: <20130522111528.GD28346@intel.com>
References: <1368006628-24628-1-git-send-email-ville.syrjala@linux.intel.com>
	<1368006628-24628-3-git-send-email-ville.syrjala@linux.intel.com>
	<20130521151726.GG17947@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id 139F1E60BD
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 22 May 2013 04:15:32 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20130521151726.GG17947@debian>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Egbert Eich <eich@freedesktop.org>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 21, 2013 at 05:17:27PM +0200, Egbert Eich wrote:
> On Wed, May 08, 2013 at 12:50:24PM +0300, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > Follow the same sequence when enabling the cursor plane during
> > modeset. No point in doing this stuff in different order on different
> > generations.
> > =

> > This should also avoid a needless wait for vblank for the g4x cursor
> > workaround when the cursor gets enabled anyway.
> > =

> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_display.c | 10 ++++------
> >  1 file changed, 4 insertions(+), 6 deletions(-)
> > =

> > @@ -3727,6 +3725,7 @@ static void i9xx_crtc_enable(struct drm_crtc *crt=
c)
> >  =

> >  	intel_enable_pipe(dev_priv, pipe, false);
> >  	intel_enable_plane(dev_priv, plane, pipe);
> > +	intel_crtc_update_cursor(crtc, true);
> >  	if (IS_G4X(dev))
> >  		g4x_fixup_plane(dev_priv, pipe);
> >  =

> =

> As discussed on IRC this may interfere with =

> =

> commit 61bc95c1fbbb6a08b55bbe161fdf1ea5493fc595
> Author: Egbert Eich <eich@suse.com>
> Date:   Mon Mar 4 09:24:38 2013 -0500
> =

>     DRM/i915: On G45 enable cursor plane briefly after enabling the displ=
ay plane.
> =

> described in https://bugs.freedesktop.org/show_bug.cgi?id=3D61457
> =

> I cannot test on the affected hardware as it's not available to
> me at the moment. If Ville's G4x doesn't show the issue I will =

> test this next time I have access to the HW in question.

I couldn't reproduce the original problem on my g4x :(

> Therefore:
> =

> Acked-by: Egbert Eich <eich@suse.com>
> =

> Cheers,
> 	Egbert.

-- =

Ville Syrj=E4l=E4
Intel OTC