From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 22 May 2013 17:22:54 -0400 Subject: [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL In-Reply-To: References: <1368759917-6348-1-git-send-email-ying.zhang@freescale.com> <1369076175.5246.2@scott-Lenovo-G560> <1369163690.1374.9@scott-Lenovo-G560> <519C6103.3000008@denx.de> Message-ID: <20130522212254.GH10368@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, May 22, 2013 at 08:06:01AM +0000, Zhang Ying-B40530 wrote: > > > -----Original Message----- > From: Stefan Roese [mailto:sr at denx.de] > Sent: Wednesday, May 22, 2013 2:09 PM > To: Wood Scott-B07421 > Cc: Zhang Ying-B40530; Wood Scott-B07421; Xie at theia.denx.de; u-boot at lists.denx.de; afleming at gmail.com > Subject: Re: [U-Boot] [PATCH] common/Makefile: Add new symbol CONFIG_SPL_ENV_SUPPORT for environment in SPL > > (sorry for jumping in so late in this discussion) > > On 05/21/2013 09:14 PM, Scott Wood wrote: > >> This is Tom's words: > >> > >> a3m071 relies on SPL always building cmd_nvedit.o and env_common.o and > >> duplicated CONFIG_ENV_IS_IN_FLASH in the SPL section. > >> > >> CONFIG_SPL_NET_SUPPORT relies on the same always-built ins and adds > >> env_nowhere.o which works because the regular CONFIG_ENV_IS_IN_... > >> > >> section is in the non-SPL-only area. > > > > If "SPL: Makefile: Build a separate autoconf.mk for SPL" gets merged, > > we could just have a3m071 define CONFIG_ENV_IS_NOWHERE in the SPL build > > case. > > But the a3m071 SPL U-Boot version also uses the env from NOR flash. So > defining CONFIG_ENV_IS_NOWHERE here would be really confusing! > [Zhang Ying] > I think Scott means that the specific boards CONFIG_SPL_NET_SUPPORT > is set should define CONFIG_ENV_IS_NOWHERE in the SPL build case. For > example: am335x and pcm051. Correct. I need to see if I can reproduce the problem I had with Joel's patch however. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: