From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [TINYCOMPRESS][PATCH 1/1] compress: fix hpointer error when no sample rate Date: Thu, 23 May 2013 07:58:37 +0530 Message-ID: <20130523022837.GU14863@intel.com> References: <20130502135853.GA2744@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by alsa0.perex.cz (Postfix) with ESMTP id 1091A2619D9 for ; Thu, 23 May 2013 05:04:59 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20130502135853.GA2744@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Richard Fitzgerald Cc: pierre-louis.bossart@linux.jf.intel.com, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, ckeepax@opensource.wolfsonmicro.com, vinod.koul@linux.jf.intel.com List-Id: alsa-devel@alsa-project.org On Thu, May 02, 2013 at 02:58:53PM +0100, Richard Fitzgerald wrote: > Fixes the oops() in compress_get_hpointer() to return > -ENODATA instead of errno if the sample rate is zero. > The value in errno here is not related to the reason > we are returning an error. > > Signed-off-by: Richard Fitzgerald Applied thanks -- ~Vinod > --- > compress.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/compress.c b/compress.c > index e80e598..abd0799 100644 > --- a/compress.c > +++ b/compress.c > @@ -315,7 +315,7 @@ int compress_get_hpointer(struct compress *compress, > if (ioctl(compress->fd, SNDRV_COMPRESS_AVAIL, &kavail)) > return oops(compress, errno, "cannot get avail"); > if (0 == kavail.tstamp.sampling_rate) > - return oops(compress, errno, "invalid paramter"); > + return oops(compress, -ENODATA, "sample rate unknown"); > *avail = (unsigned int)kavail.avail; > time = kavail.tstamp.pcm_io_frames / kavail.tstamp.sampling_rate; > tstamp->tv_sec = time; > -- > 1.7.2.5 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel