From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. Date: Thu, 23 May 2013 10:54:10 +0200 Message-ID: <201305231054.10735.arnd@arndb.de> References: <519DCBEF.3090208@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Geert Uytterhoeven Cc: Catalin Marinas , Linux-sh list , Chen Gang , Heiko Carstens , "paulus@samba.org" , "H. Peter Anvin" , Michel Lespinasse , Hans-Christian Egtvedt , Linux-Arch , linux-s390@vger.kernel.org, Russell King - ARM Linux , Yoshinori Sato , Richard Weinberger , Helge Deller , the arch/x86 maintainers , "James E.J. Bottomley" , "mingo@redhat.com" , Frederic Weisbecker , Paul McKenney , =?utf-8?q?H=C3=A5vard_Skinnemoen?= , Serge Hallyn , Mike List-Id: linux-arch.vger.kernel.org On Thursday 23 May 2013, Geert Uytterhoeven wrote: > > -config BUG > > - bool "BUG() support" if EXPERT > > - default y > > - help > > - Disabling this option eliminates support for BUG and WARN, reducing > > - the size of your kernel image and potentially quietly ignoring > > - numerous fatal conditions. You should only consider disabling this > > - option for embedded systems with no facilities for reporting errors. > > - Just say Y. > > ... It's about reducing memory size on devices where you can't show bug or > warning messages. > > > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. > > So please keep it. Agreed. The one annoying property of disabling BUG() support is that it causes a large number of build warnings since the compiler now has to assume that a lot of code is reachable when it is normally annotate as unreachable. When I do "randconfig" tests, I always turn on CONFIG_BUG because of this. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Arnd Bergmann Date: Thu, 23 May 2013 10:54:10 +0200 References: <519DCBEF.3090208@asianux.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201305231054.10735.arnd@arndb.de> Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. To: Geert Uytterhoeven Cc: Chen Gang , Russell King - ARM Linux , =?utf-8?q?H=C3=A5vard_Skinnemoen?= , Hans-Christian Egtvedt , Mike Frysinger , Yoshinori Sato , Richard Kuo , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , "paulus@samba.org" , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, Paul Mundt , Jeff Dike , Richard Weinberger , Thomas Gleixner , "mingo@redhat.com" , "H. Peter Anvin" , the arch/x86 maintainers , "Eric W. Biederman" , Serge Hallyn , Paul McKenney , Frederic Weisbecker , David Miller , Andrew Morton , Akinobu Mita , Catalin Marinas , Michel Lespinasse , Will Deacon , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "uclinux-dist-devel@blackfin.uclinux.org" , linux-hexagon@vger.kernel.org, Parisc List , "linuxppc-dev@lists.ozlabs.org" , linux-s390@vger.kernel.org, Linux-sh list , uml-devel , uml-user , Linux-Arch List-ID: On Thursday 23 May 2013, Geert Uytterhoeven wrote: > > -config BUG > > - bool "BUG() support" if EXPERT > > - default y > > - help > > - Disabling this option eliminates support for BUG and WARN, reducing > > - the size of your kernel image and potentially quietly ignoring > > - numerous fatal conditions. You should only consider disabling this > > - option for embedded systems with no facilities for reporting errors. > > - Just say Y. > > ... It's about reducing memory size on devices where you can't show bug or > warning messages. > > > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. > > So please keep it. Agreed. The one annoying property of disabling BUG() support is that it causes a large number of build warnings since the compiler now has to assume that a lot of code is reachable when it is normally annotate as unreachable. When I do "randconfig" tests, I always turn on CONFIG_BUG because of this. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.17.9]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 10B012C007E for ; Thu, 23 May 2013 18:58:36 +1000 (EST) From: Arnd Bergmann To: Geert Uytterhoeven Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. Date: Thu, 23 May 2013 10:54:10 +0200 References: <519DCBEF.3090208@asianux.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Message-Id: <201305231054.10735.arnd@arndb.de> Cc: Catalin Marinas , Linux-sh list , Chen Gang , Heiko Carstens , "paulus@samba.org" , "H. Peter Anvin" , Michel Lespinasse , Hans-Christian Egtvedt , Linux-Arch , linux-s390@vger.kernel.org, Russell King - ARM Linux , Yoshinori Sato , Richard Weinberger , Helge Deller , the arch/x86 maintainers , "James E.J. Bottomley" , "mingo@redhat.com" , Frederic Weisbecker , Paul McKenney , =?utf-8?q?H=C3=A5vard_Skinnemoen?= , Serge Hallyn , Mike Frysinger , uml-devel , Will Deacon , Jeff Dike , Akinobu Mita , uml-user , "uclinux-dist-devel@blackfin.uclinux.org" , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Parisc List , "linux-kernel@vger.kernel.org" , Richard Kuo , Paul Mundt , "Eric W. Biederman" , linux-hexagon@vger.kernel.org, Martin Schwidefsky , linux390@de.ibm.com, Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , David Miller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thursday 23 May 2013, Geert Uytterhoeven wrote: > > -config BUG > > - bool "BUG() support" if EXPERT > > - default y > > - help > > - Disabling this option eliminates support for BUG and WARN, reducing > > - the size of your kernel image and potentially quietly ignoring > > - numerous fatal conditions. You should only consider disabling this > > - option for embedded systems with no facilities for reporting errors. > > - Just say Y. > > ... It's about reducing memory size on devices where you can't show bug or > warning messages. > > > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. > > So please keep it. Agreed. The one annoying property of disabling BUG() support is that it causes a large number of build warnings since the compiler now has to assume that a lot of code is reachable when it is normally annotate as unreachable. When I do "randconfig" tests, I always turn on CONFIG_BUG because of this. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 23 May 2013 10:54:10 +0200 Subject: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. In-Reply-To: References: <519DCBEF.3090208@asianux.com> Message-ID: <201305231054.10735.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 23 May 2013, Geert Uytterhoeven wrote: > > -config BUG > > - bool "BUG() support" if EXPERT > > - default y > > - help > > - Disabling this option eliminates support for BUG and WARN, reducing > > - the size of your kernel image and potentially quietly ignoring > > - numerous fatal conditions. You should only consider disabling this > > - option for embedded systems with no facilities for reporting errors. > > - Just say Y. > > ... It's about reducing memory size on devices where you can't show bug or > warning messages. > > > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. > > So please keep it. Agreed. The one annoying property of disabling BUG() support is that it causes a large number of build warnings since the compiler now has to assume that a lot of code is reachable when it is normally annotate as unreachable. When I do "randconfig" tests, I always turn on CONFIG_BUG because of this. Arnd