From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH resend nf-next] netfilter: xt_CT: optimize XT_CT_NOTRACK
Date: Thu, 23 May 2013 12:54:04 +0200 [thread overview]
Message-ID: <20130523105404.GB22507@localhost> (raw)
In-Reply-To: <1369257057.3301.367.camel@edumazet-glaptop>
On Wed, May 22, 2013 at 02:10:57PM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> The percpu untracked ct are not currently used for XT_CT_NOTRACK.
>
> xt_ct_tg_check()/xt_ct_target() provides a single ct.
>
> Thats not optimal as the ct->ct_general.use cache line will bounce among
> cpus.
>
> Use the intended [1] thing : xt_ct_target() should select the percpu
> object.
>
> [1] Refs :
> commit 5bfddbd46a95c97 ("netfilter: nf_conntrack: IPS_UNTRACKED bit")
> commit b3c5163fe0193a7 ("netfilter: nf_conntrack: per_cpu untracking")
Applied, thanks Eric.
prev parent reply other threads:[~2013-05-23 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 20:52 [PATCH nf-next] netfilter: xt_CT: optimize XT_CT_NOTRACK Eric Dumazet
2013-05-22 21:10 ` [PATCH resend " Eric Dumazet
2013-05-23 10:54 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523105404.GB22507@localhost \
--to=pablo@netfilter.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.