From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: kaber@trash.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, David Miller <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ipv4: netfilter: always let NUL terminated string ended by '\0'
Date: Thu, 23 May 2013 13:08:32 +0200 [thread overview]
Message-ID: <20130523110832.GB22553@localhost> (raw)
In-Reply-To: <5195ECB3.5000006@asianux.com>
On Fri, May 17, 2013 at 04:39:15PM +0800, Chen Gang wrote:
>
> For NUL terminated string, better always be sure of ended by '\0'.
>
> 'pm' is 'struct ulog_packet_msg_t' which may be copied to user mode
> (defined in "include/uapi/..."), so can not use strlcpy() instead of.
loginfo->prefix is always nul-terminated, as this is validated in
checkentry. I don't think the kernel will take a non nul-terminated
device name either.
next prev parent reply other threads:[~2013-05-23 11:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 8:39 [PATCH] ipv4: netfilter: always let NUL terminated string ended by '\0' Chen Gang
2013-05-23 11:08 ` Pablo Neira Ayuso [this message]
2013-05-23 11:39 ` Chen Gang
2013-05-23 11:49 ` Pablo Neira Ayuso
2013-05-23 11:49 ` Pablo Neira Ayuso
2013-05-23 11:59 ` Chen Gang
2013-05-23 11:50 ` [PATCH v2] " Chen Gang
2013-05-23 12:26 ` Pablo Neira Ayuso
2013-05-24 1:11 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523110832.GB22553@localhost \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=gang.chen@asianux.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.