From: rjohnston@sgi.com
To: xfs@oss.sgi.com
Subject: [PATCH V2] xfsprogs: libhandle/Makefile - fix make install-dev
Date: Thu, 23 May 2013 08:52:52 -0500 [thread overview]
Message-ID: <20130523133837.333783222@sgi.com> (raw)
In-Reply-To: 20130522205819.586978467@gulag1.americas.sgi.com
The dependency for install-dev: is incorrect "default" and prevents libhandle
from being installed correctly.
After make && make install-dev
# ls -l /lib64/libhandle* /usr/lib64/libhandle*
lrwxrwxrwx 1 root root /lib64/libhandle.a -> /usr/lib64/libhandle.a
lrwxrwxrwx 1 root root /lib64/libhandle.la -> /usr/lib64/libhandle.la
lrwxrwxrwx 1 root root /lib64/libhandle.so -> libhandle.so.1
-rw-r--r-- 1 root root /usr/lib64/libhandle.a
-rw-r--r-- 1 root root /usr/lib64/libhandle.la
lrwxrwxrwx 1 root root /usr/lib64/libhandle.so -> /lib64/libhandle.so
The shared library /lib64/libhandle.so.1.0.3 is not installed and
the link /lib64/libhandle.so.1 -> libhandle.so.1.0.3 is not created.
Change the dependency for install-dev: to "install" so the install looks like
this.
# ls -l /lib64/libhandle* /usr/lib64/libhandle*
lrwxrwxrwx 1 root root /lib64/libhandle.a -> /usr/lib64/libhandle.a
lrwxrwxrwx 1 root root /lib64/libhandle.la -> /usr/lib64/libhandle.la
lrwxrwxrwx 1 root root /lib64/libhandle.so -> libhandle.so.1
lrwxrwxrwx 1 root root /lib64/libhandle.so.1 -> libhandle.so.1.0.3
-rwxr-xr-x 1 root root /lib64/libhandle.so.1.0.3
-rw-r--r-- 1 root root /usr/lib64/libhandle.a
-rw-r--r-- 1 root root /usr/lib64/libhandle.la
lrwxrwxrwx 1 root root /usr/lib64/libhandle.so -> /lib64/libhandle.so
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
--
V1->V2
As Dave pointed out removing the ltdepend would prevent proper rebuilds.
Don't just make the install work ;) correct the dependency for install-dev.
diff --git a/libhandle/Makefile b/libhandle/Makefile
index 865ca22..081a386 100644
--- a/libhandle/Makefile
+++ b/libhandle/Makefile
@@ -22,7 +22,7 @@ include $(BUILDRULES)
install: default
$(INSTALL_LTLIB)
-install-dev: default
+install-dev: install
$(INSTALL_LTLIB_DEV)
install-qa: install-dev
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-23 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 20:58 [PATCH] xfsprogs: libhandle/Makefile - fix make install rjohnston
2013-05-22 21:22 ` Eric Sandeen
2013-05-22 22:05 ` Rich Johnston
2013-05-22 23:04 ` Dave Chinner
2013-05-22 22:16 ` Dave Chinner
2013-05-23 13:52 ` rjohnston [this message]
2013-05-23 15:37 ` [PATCH V3] xfsprogs: libhandle/Makefile - fix make install-dev rjohnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523133837.333783222@sgi.com \
--to=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.