All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>,
	Aaron Schrab <aaron@schrab.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] Document push --no-verify
Date: Thu, 23 May 2013 17:37:11 +0300	[thread overview]
Message-ID: <20130523143711.GA24037@redhat.com> (raw)
In-Reply-To: <ba24ea6f9fedc05690ee93a805d4f468650a942c.1369315855.git.trast@inf.ethz.ch>

On Thu, May 23, 2013 at 03:34:11PM +0200, Thomas Rast wrote:
> ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
> add a note to git-push(1) about the new --no-verify option.
> 
> Signed-off-by: Thomas Rast <trast@inf.ethz.ch>


Thanks. FWIW

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
> 
> Junio replied privately that it should also mention the --verify
> possibility.
> 
> So why not.  But this needs to be fixed across the board eventually;
> 0f1930c (parse-options: allow positivation of options starting, with
> no-, 2012-02-25) did not update any docs, so none of the other --no-
> options mention their positive forms.
> 
> 
>  Documentation/git-push.txt | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index d514813..df5be26 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -11,7 +11,7 @@ SYNOPSIS
>  [verse]
>  'git push' [--all | --mirror | --tags] [--follow-tags] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
>  	   [--repo=<repository>] [-f | --force] [--prune] [-v | --verbose] [-u | --set-upstream]
> -	   [<repository> [<refspec>...]]
> +	   [--no-verify] [<repository> [<refspec>...]]
>  
>  DESCRIPTION
>  -----------
> @@ -195,6 +195,11 @@ useful if you write an alias or script around 'git push'.
>  	be pushed. If on-demand was not able to push all necessary
>  	revisions it will also be aborted and exit with non-zero status.
>  
> +--[no-]verify::
> +	Toggle the pre-push hook (see linkgit:githooks[5]).  The
> +	default is \--verify, giving the hook a chance to prevent the
> +	push.  With \--no-verify, the hook is bypassed completely.
> +
>  
>  include::urls-remotes.txt[]
>  
> -- 
> 1.8.3.rc3.486.gfe16094

      reply	other threads:[~2013-05-23 14:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22  9:23 [PATCH] Document push --no-verify Thomas Rast
2013-05-22 17:17 ` Junio C Hamano
2013-05-22 20:23   ` Thomas Rast
2013-05-23 13:34     ` [PATCH v2] " Thomas Rast
2013-05-23 14:37       ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130523143711.GA24037@redhat.com \
    --to=mst@redhat.com \
    --cc=aaron@schrab.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=trast@inf.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.