Re: [Qemu-devel] [PATCH 00/10] virtio: import headers from linux

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, May 23, 2013 at 05:56:43PM +0300, Michael S. Tsirkin wrote:
> On Thu, May 23, 2013 at 03:41:07PM +0100, Peter Maydell wrote:
> > On 23 May 2013 15:34, Michael S. Tsirkin <mst@redhat.com> wrote:
> > > I'm working on adding new virtio layout to qemu.
> > > The job is complicated by the fact that
> > > qemu has its own copy of the virtio headers,
> > > sometimes with slightly different names
> > > and structure.
> > > Import headers from linux instead.
> > 
> > Do the kernel guys guarantee that their headers will
> > compile on all the platforms QEMU supports? [eg windows]
> > (this isn't an issue for the current uses of linux-headers
> > because we only use it for KVM support, and if KVM is
> > enabled you're definitely on a Linux host.)
> > 
> > thanks
> > -- PMM
> 
> No but at the moment there's nothing there besides harmless
> defines.
> 
> But it's not like we update these things automatically.
> 
> If/when things break, we can change update-headers to strip
> problematic stuff out of there.

Or so I thought but in practice there's a dependency
on linux/types.h
However, that's pretty easy to address.
I can think of two ways:
    - strip linux/types.h in update_headers
    - add a stub linux/types.h for non linux platforms

Preferences?

> -- 
> MST