All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Natapov <gleb@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	kvm <kvm@vger.kernel.org>, Marcelo Tosatti <mtosatti@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [GIT PULL] KVM fixes for 3.10-rc2
Date: Thu, 23 May 2013 20:13:58 +0300	[thread overview]
Message-ID: <20130523171358.GN26157@redhat.com> (raw)
In-Reply-To: <CA+55aFxA8AJLi3gvHKVuNdR+Yu2ZGRAbLnxTL4BVo6vY3fRYxA@mail.gmail.com>

On Thu, May 23, 2013 at 09:20:22AM -0700, Linus Torvalds wrote:
> On Thu, May 23, 2013 at 3:41 AM, Gleb Natapov <gleb@redhat.com> wrote:
> >
> >  MAINTAINERS                      |    7 ++--
> >  arch/mips/include/asm/kvm.h      |   55 ---------------------------------------
> >  arch/mips/include/uapi/asm/kvm.h |   55 +++++++++++++++++++++++++++++++++++++++
> >  arch/mips/kvm/kvm_tlb.c          |   35 ++++++++++++++++++------
> >  4 files changed, 85 insertions(+), 67 deletions(-)
> 
> This was wrong. Please make sure you use the "-M" flag to make git
> diff look for file renames, and the "--summary" flag to show metadata
> changes separately.
> 
> IOW, it *should* have looked like this:
> 
>  MAINTAINERS                            |  7 ++++---
>  arch/mips/include/{ => uapi}/asm/kvm.h |  0
>  arch/mips/kvm/kvm_tlb.c                | 35 ++++++++++++++++++++++++++---------
>  3 files changed, 30 insertions(+), 12 deletions(-)
>  rename arch/mips/include/{ => uapi}/asm/kvm.h (100%)
> 
Ugh, yes "-M" and "--summary" were missing. I updated the script now. Thanks!
Should I regenerate pull request?

--
			Gleb.

  reply	other threads:[~2013-05-23 17:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-23 10:41 [GIT PULL] KVM fixes for 3.10-rc2 Gleb Natapov
2013-05-23 16:20 ` Linus Torvalds
2013-05-23 17:13   ` Gleb Natapov [this message]
2013-05-23 17:14     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130523171358.GN26157@redhat.com \
    --to=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.