From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH 05/11] mm: thp: Correct the HPAGE_PMD_ORDER check. Date: Fri, 24 May 2013 12:18:42 +0100 Message-ID: <20130524111842.GI18272@arm.com> References: <1369328878-11706-1-git-send-email-steve.capper@linaro.org> <1369328878-11706-6-git-send-email-steve.capper@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1369328878-11706-6-git-send-email-steve.capper@linaro.org> Sender: owner-linux-mm@kvack.org To: Steve Capper Cc: "linux-mm@kvack.org" , "x86@kernel.org" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michal Hocko , Ken Chen , Mel Gorman , Will Deacon , "patches@linaro.org" List-Id: linux-arch.vger.kernel.org On Thu, May 23, 2013 at 06:07:52PM +0100, Steve Capper wrote: > All Transparent Huge Pages are allocated by the buddy allocator. > > A compile time check is in place that fails when the order of a > transparent huge page is too large to be allocated by the buddy > allocator. Unfortunately that compile time check passes when: > HPAGE_PMD_ORDER == MAX_ORDER > ( which is incorrect as the buddy allocator can only allocate > memory of order strictly less than MAX_ORDER. ) > > This patch updates the compile time check to fail in the above > case. > > Signed-off-by: Steve Capper Acked-by: Catalin Marinas -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:43505 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751633Ab3EXLTZ (ORCPT ); Fri, 24 May 2013 07:19:25 -0400 Date: Fri, 24 May 2013 12:18:42 +0100 From: Catalin Marinas Subject: Re: [PATCH 05/11] mm: thp: Correct the HPAGE_PMD_ORDER check. Message-ID: <20130524111842.GI18272@arm.com> References: <1369328878-11706-1-git-send-email-steve.capper@linaro.org> <1369328878-11706-6-git-send-email-steve.capper@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1369328878-11706-6-git-send-email-steve.capper@linaro.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Steve Capper Cc: "linux-mm@kvack.org" , "x86@kernel.org" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Michal Hocko , Ken Chen , Mel Gorman , Will Deacon , "patches@linaro.org" Message-ID: <20130524111842.FaNatTncSirMK9pEK7_1FyN1dcExE6bN6Hoef5Hu5Bo@z> On Thu, May 23, 2013 at 06:07:52PM +0100, Steve Capper wrote: > All Transparent Huge Pages are allocated by the buddy allocator. > > A compile time check is in place that fails when the order of a > transparent huge page is too large to be allocated by the buddy > allocator. Unfortunately that compile time check passes when: > HPAGE_PMD_ORDER == MAX_ORDER > ( which is incorrect as the buddy allocator can only allocate > memory of order strictly less than MAX_ORDER. ) > > This patch updates the compile time check to fail in the above > case. > > Signed-off-by: Steve Capper Acked-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Fri, 24 May 2013 12:18:42 +0100 Subject: [PATCH 05/11] mm: thp: Correct the HPAGE_PMD_ORDER check. In-Reply-To: <1369328878-11706-6-git-send-email-steve.capper@linaro.org> References: <1369328878-11706-1-git-send-email-steve.capper@linaro.org> <1369328878-11706-6-git-send-email-steve.capper@linaro.org> Message-ID: <20130524111842.GI18272@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 23, 2013 at 06:07:52PM +0100, Steve Capper wrote: > All Transparent Huge Pages are allocated by the buddy allocator. > > A compile time check is in place that fails when the order of a > transparent huge page is too large to be allocated by the buddy > allocator. Unfortunately that compile time check passes when: > HPAGE_PMD_ORDER == MAX_ORDER > ( which is incorrect as the buddy allocator can only allocate > memory of order strictly less than MAX_ORDER. ) > > This patch updates the compile time check to fail in the above > case. > > Signed-off-by: Steve Capper Acked-by: Catalin Marinas