From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Fri, 24 May 2013 13:53:14 +0100 Subject: [PATCH] ARM: ux500: enable the crypto and hash on all dbx500 In-Reply-To: References: <1369378122-25897-1-git-send-email-linus.walleij@stericsson.com> <20130524082758.GP22683@gmail.com> Message-ID: <20130524125314.GZ22683@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 24 May 2013, Linus Walleij wrote: > On Fri, May 24, 2013 at 10:27 AM, Lee Jones wrote: > > On Fri, 24 May 2013, Linus Walleij wrote: > >> From: Linus Walleij > >> > >> Commits: > >> "ARM: ux500: Add Device Tree nodes for the ux500 Crypt device" > >> "ARM: ux500: Add Device Tree nodes for the ux500 Hash device" > >> > >> Added the crypto and hash devices conditionally, i.e. so as to > >> be turned on per-board by setting an "status" property on the > >> device from "disabled" to "okay" on each device. > >> > >> This is wrong since this is an SoC feature, it is not board > >> dependent. It is the same ASIC under all circumstances and > >> functionality does not vary with board family. > >> > >> This moves the enablement into the SoC file. > >> > >> Cc: Lee Jones > >> Signed-off-by: Linus Walleij > >> --- > >> arch/arm/boot/dts/dbx5x0.dtsi | 4 ---- > >> arch/arm/boot/dts/snowball.dts | 8 -------- > >> 2 files changed, 12 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi > >> index f051963..cd5cd09 100644 > >> --- a/arch/arm/boot/dts/dbx5x0.dtsi > >> +++ b/arch/arm/boot/dts/dbx5x0.dtsi > >> @@ -760,17 +760,13 @@ > >> compatible = "stericsson,ux500-cryp"; > >> reg = <0xa03cb000 0x1000>; > >> interrupts = <0 15 0x4>; > >> - > > > > Why do you insist on removing all line spacings from the DTS file? > > > > I saw you removing them in between nodes too. > > I was hit by a linespace when I was a child, since then I take > every opportunity for revenge. :) > If I keep the spacing, can I have your ACK? You can. For reference, I like a space separating all nodes too. :) -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] ARM: ux500: enable the crypto and hash on all dbx500 Date: Fri, 24 May 2013 13:53:14 +0100 Message-ID: <20130524125314.GZ22683@gmail.com> References: <1369378122-25897-1-git-send-email-linus.walleij@stericsson.com> <20130524082758.GP22683@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Linus Walleij Cc: "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Gabriel Fernandez , Linus Walleij , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org T24gRnJpLCAyNCBNYXkgMjAxMywgTGludXMgV2FsbGVpaiB3cm90ZToKCj4gT24gRnJpLCBNYXkg MjQsIDIwMTMgYXQgMTA6MjcgQU0sIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+IHdy b3RlOgo+ID4gT24gRnJpLCAyNCBNYXkgMjAxMywgTGludXMgV2FsbGVpaiB3cm90ZToKPiA+PiBG cm9tOiBMaW51cyBXYWxsZWlqIDxsaW51cy53YWxsZWlqQGxpbmFyby5vcmc+Cj4gPj4KPiA+PiBD b21taXRzOgo+ID4+ICJBUk06IHV4NTAwOiBBZGQgRGV2aWNlIFRyZWUgbm9kZXMgZm9yIHRoZSB1 eDUwMCBDcnlwdCBkZXZpY2UiCj4gPj4gIkFSTTogdXg1MDA6IEFkZCBEZXZpY2UgVHJlZSBub2Rl cyBmb3IgdGhlIHV4NTAwIEhhc2ggZGV2aWNlIgo+ID4+Cj4gPj4gQWRkZWQgdGhlIGNyeXB0byBh bmQgaGFzaCBkZXZpY2VzIGNvbmRpdGlvbmFsbHksIGkuZS4gc28gYXMgdG8KPiA+PiBiZSB0dXJu ZWQgb24gcGVyLWJvYXJkIGJ5IHNldHRpbmcgYW4gInN0YXR1cyIgcHJvcGVydHkgb24gdGhlCj4g Pj4gZGV2aWNlIGZyb20gImRpc2FibGVkIiB0byAib2theSIgb24gZWFjaCBkZXZpY2UuCj4gPj4K PiA+PiBUaGlzIGlzIHdyb25nIHNpbmNlIHRoaXMgaXMgYW4gU29DIGZlYXR1cmUsIGl0IGlzIG5v dCBib2FyZAo+ID4+IGRlcGVuZGVudC4gSXQgaXMgdGhlIHNhbWUgQVNJQyB1bmRlciBhbGwgY2ly Y3Vtc3RhbmNlcyBhbmQKPiA+PiBmdW5jdGlvbmFsaXR5IGRvZXMgbm90IHZhcnkgd2l0aCBib2Fy ZCBmYW1pbHkuCj4gPj4KPiA+PiBUaGlzIG1vdmVzIHRoZSBlbmFibGVtZW50IGludG8gdGhlIFNv QyBmaWxlLgo+ID4+Cj4gPj4gQ2M6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+Cj4g Pj4gU2lnbmVkLW9mZi1ieTogTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3Jn Pgo+ID4+IC0tLQo+ID4+ICBhcmNoL2FybS9ib290L2R0cy9kYng1eDAuZHRzaSAgfCA0IC0tLS0K PiA+PiAgYXJjaC9hcm0vYm9vdC9kdHMvc25vd2JhbGwuZHRzIHwgOCAtLS0tLS0tLQo+ID4+ICAy IGZpbGVzIGNoYW5nZWQsIDEyIGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2Fy Y2gvYXJtL2Jvb3QvZHRzL2RieDV4MC5kdHNpIGIvYXJjaC9hcm0vYm9vdC9kdHMvZGJ4NXgwLmR0 c2kKPiA+PiBpbmRleCBmMDUxOTYzLi5jZDVjZDA5IDEwMDY0NAo+ID4+IC0tLSBhL2FyY2gvYXJt L2Jvb3QvZHRzL2RieDV4MC5kdHNpCj4gPj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvZGJ4NXgw LmR0c2kKPiA+PiBAQCAtNzYwLDE3ICs3NjAsMTMgQEAKPiA+PiAgICAgICAgICAgICAgICAgICAg ICAgY29tcGF0aWJsZSA9ICJzdGVyaWNzc29uLHV4NTAwLWNyeXAiOwo+ID4+ICAgICAgICAgICAg ICAgICAgICAgICByZWcgPSA8MHhhMDNjYjAwMCAweDEwMDA+Owo+ID4+ICAgICAgICAgICAgICAg ICAgICAgICBpbnRlcnJ1cHRzID0gPDAgMTUgMHg0PjsKPiA+PiAtCj4gPgo+ID4gV2h5IGRvIHlv dSBpbnNpc3Qgb24gcmVtb3ZpbmcgYWxsIGxpbmUgc3BhY2luZ3MgZnJvbSB0aGUgRFRTIGZpbGU/ Cj4gPgo+ID4gSSBzYXcgeW91IHJlbW92aW5nIHRoZW0gaW4gYmV0d2VlbiBub2RlcyB0b28uCj4g Cj4gSSB3YXMgaGl0IGJ5IGEgbGluZXNwYWNlIHdoZW4gSSB3YXMgYSBjaGlsZCwgc2luY2UgdGhl biBJIHRha2UKPiBldmVyeSBvcHBvcnR1bml0eSBmb3IgcmV2ZW5nZS4KCjopCgo+IElmIEkga2Vl cCB0aGUgc3BhY2luZywgY2FuIEkgaGF2ZSB5b3VyIEFDSz8KCllvdSBjYW4uCgpGb3IgcmVmZXJl bmNlLCBJIGxpa2UgYSBzcGFjZSBzZXBhcmF0aW5nIGFsbCBub2RlcyB0b28uIDopCgotLSAKTGVl IEpvbmVzCkxpbmFybyBTVC1Fcmljc3NvbiBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKU giBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJv b2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkZXZpY2V0cmVlLWRpc2N1c3MgbWFpbGluZyBsaXN0CmRldmljZXRyZWUtZGlz Y3Vzc0BsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9k ZXZpY2V0cmVlLWRpc2N1c3MK