From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: imx28: Adjust i2c interrupt bindings
Date: Fri, 24 May 2013 15:57:23 +0200 [thread overview]
Message-ID: <201305241557.23904.marex@denx.de> (raw)
In-Reply-To: <1369382887.4117.34.camel@weser.hi.pengutronix.de>
Dear Lucas Stach,
> Am Donnerstag, den 23.05.2013, 19:51 +0200 schrieb Alexandre Belloni:
> > Hi,
>
> [...]
>
> > > So while we _might_ be able to get the PIO mode to work on the i.MX23
> > > there is nothing in the doc stating that it's even meant to work. Even
> > > while PIO and DMA mode use the same internal mechanisms, there's still
> > > plenty of opportunities of fail in there. After all PIO mode relies on
> > > reading a debug register in the course of normal operation.
> > >
> > > Only more extensive experimentation could show if we are in fact able
> > > to make it work, a first shot of using PIO mode on MX23 failed, so it
> > > might as well be that Juergens quick fix is correct and we have to
> > > disable PIO mode on MX23 altogether. That said please stop slapping
> > > the word "hack" over this patch until proven otherwise.
> >
> > Still, Fabio and I have been experiencing the one second delay on
> > i.mx28. From my experience, it appeared between 3.7 and 3.9, see:
> > http://www.spinics.net/lists/linux-i2c/msg11985.html. I still didn't
> > take the time to investigate more yet but it confirms that PIO mode is
> > working on i.mx28 though with an annoying delay.
>
> Just for the record: I know that PIO mode is functional on i.MX28
> because I have it working on one of our customer boards. I am rather
> much surprised it's still not working well for you, but haven't had a
> chance to investigate yet. The i.MX28 RM explicitly describes how to
> work with the PIO mode, so if it's not working this is bug somewhere.
I won't be surprised if there was more than one. The RM describes something ,
but has many flaws. I'm sure you noticed that yourself.
> This thread/patch is about a whole different problem, namely PIO mode
> being non-functional on i.MX23. As the i.MX23 RM doesn't describe the
> PIO mode, there is no indication that it's even meant to work on this
> chip.
I'm not against the patch per-se, but can we not get the best of this and
instead try some more to fix the PIO on MX23 so the MX23 users won't suffer
performance degradation on already weak CPU?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-05-24 13:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 14:13 [PATCH 1/2] ARM: dts: imx: Remove custom dma-channel bindings Fabio Estevam
2013-05-16 14:13 ` [PATCH 2/2] ARM: dts: imx28: Adjust i2c interrupt bindings Fabio Estevam
2013-05-16 15:50 ` Fabio Estevam
2013-05-16 17:25 ` Fabio Estevam
2013-05-16 19:33 ` Alexandre Belloni
2013-05-17 0:10 ` Fabio Estevam
2013-05-22 10:19 ` Juergen Beisert
2013-05-22 11:05 ` Marek Vasut
2013-05-23 7:20 ` Juergen Beisert
2013-05-23 14:48 ` Marek Vasut
2013-05-23 15:28 ` Lucas Stach
2013-05-23 17:51 ` Alexandre Belloni
2013-05-24 8:08 ` Lucas Stach
2013-05-24 13:57 ` Marek Vasut [this message]
2013-05-24 1:00 ` Marek Vasut
2013-05-22 13:41 ` Fabio Estevam
2013-07-17 17:05 ` Marek Vasut
2013-05-17 2:25 ` [PATCH 1/2] ARM: dts: imx: Remove custom dma-channel bindings Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305241557.23904.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.