From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: replace snb_update_wm with
 haswell_update_wm on HSW
Date: Fri, 24 May 2013 19:20:54 +0300
Message-ID: <20130524162054.GJ5004@intel.com>
References: <1367872696-4617-1-git-send-email-przanoni@gmail.com>
	<1368130422-15392-1-git-send-email-przanoni@gmail.com>
	<20130520155607.GL14974@intel.com>
	<CA+gsUGTROr8hdzeYicyW0DRhRmW+4p4eJ+4GUaQ+PFZz7tLwVQ@mail.gmail.com>
	<20130522072519.GA28346@intel.com>
	<CA+gsUGQs9=hwb=o34-PDdnhwX2=_PT86wqjMzrPxrNH9Turk-Q@mail.gmail.com>
	<20130524160745.GI15743@phenom.ffwll.local>
	<CAKMK7uGDqmB13pfQFCqVWSjG23COgGww4=7AFoOt9yFJ2_NLFw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5F962E6536
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 24 May 2013 09:20:58 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAKMK7uGDqmB13pfQFCqVWSjG23COgGww4=7AFoOt9yFJ2_NLFw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, May 24, 2013 at 06:13:15PM +0200, Daniel Vetter wrote:
> On Fri, May 24, 2013 at 6:07 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > pfit_size stores the request mode, which matches crtc->config.requested
> > mode. Instead of jumping through hoops I think I'd be better to directly
> > use those values ...
> =

> Scrap that, I can't read code ;-)

One change I'd like is to store the pfit window w/h as individual values
instead of sticking the raw register value into pipe_config. Nothing else
seems to be stored there in raw form, so it feels inconsistent. And it
would avoid the mask/shift busniness when extracting the values.

-- =

Ville Syrj=E4l=E4
Intel OTC