From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 2.mo4.mail-out.ovh.net ([46.105.72.36] helo=mo4.mail-out.ovh.net) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Ufy9f-0006v3-BU for linux-mtd@lists.infradead.org; Fri, 24 May 2013 20:00:00 +0000 Received: from mail172.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo4.mail-out.ovh.net (Postfix) with SMTP id 84C7110544BD for ; Fri, 24 May 2013 21:59:37 +0200 (CEST) Date: Fri, 24 May 2013 21:55:25 +0200 From: Jean-Christophe PLAGNIOL-VILLARD To: Josh Wu Subject: Re: [PATCH v2 0/4] mtd: atmel_nand: enable Nand Flash Controller (NFC) support Message-ID: <20130524195525.GL24476@game.jcrosoft.org> References: <1368784308-7600-1-git-send-email-josh.wu@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368784308-7600-1-git-send-email-josh.wu@atmel.com> Cc: nicolas.ferre@atmel.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 17:51 Fri 17 May , Josh Wu wrote: > This patch series enable NFC support for SAMA5 soc. It can send command, > address cycles automaticly. Also when enable NFC sram, NFC will transfer > data to sram. Which can save lots of cpu time. can you give some stats please and performance comparaisan NFS vs DMA Best Regards, J. > > v1 --> v2: > 1) rebase it with latest l2-mtd git tree: > - remove useless nand commands (NAND_CMD_DEPLETE1, NAND_CMD_STATUS_ERRORx). > - adopt to the new nand write function's parameters. Add error message when > handle subpage write via nfc sram. > 2) rewrite pmecc_enable function. Now I use exist NAND_ECC_READ/WRITE const > instead of using a new enum definition. > > Josh Wu (4): > mtd: atmel_nand: replace pmecc enable code with one function. > mtd: atmel_nand: add Nand Flash Controller (NFC) support > mtd: atmel_nand: enable Nand Flash Controller (NFC) read data via > sram > mtd: atmel_nand: enable Nand Flash Controller (NFC) write via sram > > .../devicetree/bindings/mtd/atmel-nand.txt | 4 + > drivers/mtd/nand/atmel_nand.c | 657 ++++++++++++++++++-- > drivers/mtd/nand/atmel_nand_nfc.h | 106 ++++ > 3 files changed, 718 insertions(+), 49 deletions(-) > create mode 100644 drivers/mtd/nand/atmel_nand_nfc.h > > -- > 1.7.9.5 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Fri, 24 May 2013 21:55:25 +0200 Subject: [PATCH v2 0/4] mtd: atmel_nand: enable Nand Flash Controller (NFC) support In-Reply-To: <1368784308-7600-1-git-send-email-josh.wu@atmel.com> References: <1368784308-7600-1-git-send-email-josh.wu@atmel.com> Message-ID: <20130524195525.GL24476@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 17:51 Fri 17 May , Josh Wu wrote: > This patch series enable NFC support for SAMA5 soc. It can send command, > address cycles automaticly. Also when enable NFC sram, NFC will transfer > data to sram. Which can save lots of cpu time. can you give some stats please and performance comparaisan NFS vs DMA Best Regards, J. > > v1 --> v2: > 1) rebase it with latest l2-mtd git tree: > - remove useless nand commands (NAND_CMD_DEPLETE1, NAND_CMD_STATUS_ERRORx). > - adopt to the new nand write function's parameters. Add error message when > handle subpage write via nfc sram. > 2) rewrite pmecc_enable function. Now I use exist NAND_ECC_READ/WRITE const > instead of using a new enum definition. > > Josh Wu (4): > mtd: atmel_nand: replace pmecc enable code with one function. > mtd: atmel_nand: add Nand Flash Controller (NFC) support > mtd: atmel_nand: enable Nand Flash Controller (NFC) read data via > sram > mtd: atmel_nand: enable Nand Flash Controller (NFC) write via sram > > .../devicetree/bindings/mtd/atmel-nand.txt | 4 + > drivers/mtd/nand/atmel_nand.c | 657 ++++++++++++++++++-- > drivers/mtd/nand/atmel_nand_nfc.h | 106 ++++ > 3 files changed, 718 insertions(+), 49 deletions(-) > create mode 100644 drivers/mtd/nand/atmel_nand_nfc.h > > -- > 1.7.9.5 >